From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ACECC433FE for ; Wed, 8 Dec 2021 14:22:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235045AbhLHO0E (ORCPT ); Wed, 8 Dec 2021 09:26:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231634AbhLHO0D (ORCPT ); Wed, 8 Dec 2021 09:26:03 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C813C061746; Wed, 8 Dec 2021 06:22:31 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8AABDCE217B; Wed, 8 Dec 2021 14:22:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3DE2C00446; Wed, 8 Dec 2021 14:22:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638973347; bh=FIBzjzmMAdkZSxqat5WeMZruMGsUdbtyIOju5abgt5w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bz3Og3wFrkk9PWv6eyLH3Mt1OISDTo2h0e115/rem2/uBcAPo2DWSaCERoYdArhuY k5Tq6rjH2InY7nlGO8M2mcQDQB0BJswxHd7wF9lBYhe+2HD93FcEy9ibkUF9btIfRA 8RNxNo0Zxg8CHrjOLHzMzS7iGj9Mn72JRoVAX3M7Tg4P9eWrh3icL9XtDJbIqX1Sv1 bTrSVb7YU8H70HlZsxPJ+rdaP4Zhtcdxo1Skx7+SGLKA1tpFLpI1I5HCHC+wJHNdzr o/te+NKDG4elyR/zASB9shAixR1iE+gDQNYe2sXRP6rW6nbasAo5G0mu2adRSzuEGL j6NpF+vcuD73Q== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1muxpx-00AmtE-IJ; Wed, 08 Dec 2021 14:22:25 +0000 Date: Wed, 08 Dec 2021 14:22:25 +0000 Message-ID: <87ee6n18im.wl-maz@kernel.org> From: Marc Zyngier To: Alexandre TORGUE Cc: Thomas Gleixner , Rob Herring , , , , Subject: Re: [PATCH 2/3] irqchip/stm32-exti: add STM32MP13 support In-Reply-To: References: <20211208130456.4002-1-alexandre.torgue@foss.st.com> <20211208130456.4002-3-alexandre.torgue@foss.st.com> <87fsr31aex.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: alexandre.torgue@foss.st.com, tglx@linutronix.de, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, devicetree@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexandre, On Wed, 08 Dec 2021 13:58:46 +0000, Alexandre TORGUE wrote: > > > Why does the driver need to carry these tables? This sort of > > information should really come from DT, instead of being hardcoded in > > the driver and bloating it for no reason. This all has a funny taste > > of the board files we used to have pre-DT. > > > > There are absolutely no reason to have it in driver. Honestly It has > been done in this way to have minimal changes adding this new SoC > support (and it's not smart, I agree). > > I think it is better to abandon this series. I will create a new one > which moves mapping table for MP15 and adds MP13 support to. I'm afraid you'll have to keep the in-kernel table for MP15, since the driver needs to work with old DTs. For new SoCs (such as MP13), moving the table into DT would be good. Thanks, M. -- Without deviation from the norm, progress is not possible.