* [PATCH] RISC-V: Make CONFIG_RELOCATABLE user selectable
@ 2021-10-26 21:28 Palmer Dabbelt
2021-10-27 5:07 ` Alexandre ghiti
2021-10-27 8:00 ` Andreas Schwab
0 siblings, 2 replies; 6+ messages in thread
From: Palmer Dabbelt @ 2021-10-26 21:28 UTC (permalink / raw)
To: alex
Cc: Paul Walmsley, Palmer Dabbelt, aou, linux-riscv, linux-kernel,
kernel-team, Palmer Dabbelt
From: Palmer Dabbelt <palmerdabbelt@google.com>
This should really be up to the user, as it trades off portability for
performance.
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
arch/riscv/Kconfig | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index 5dea03549493..f8a36034d54b 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -212,18 +212,6 @@ config PGTABLE_LEVELS
config LOCKDEP_SUPPORT
def_bool y
-config RELOCATABLE
- bool
- depends on MMU && 64BIT && !XIP_KERNEL
- help
- This builds a kernel as a Position Independent Executable (PIE),
- which retains all relocation metadata required to relocate the
- kernel binary at runtime to a different virtual address than the
- address it was linked at.
- Since RISCV uses the RELA relocation format, this requires a
- relocation pass at runtime even if the kernel is loaded at the
- same address it was linked at.
-
source "arch/riscv/Kconfig.socs"
source "arch/riscv/Kconfig.erratas"
@@ -433,6 +421,18 @@ config CRASH_DUMP
For more details see Documentation/admin-guide/kdump/kdump.rst
+config RELOCATABLE
+ bool "Build a relocatable kernel"
+ depends on MMU && 64BIT && !XIP_KERNEL
+ help
+ This builds a kernel as a Position Independent Executable (PIE),
+ which retains all relocation metadata required to relocate the
+ kernel binary at runtime to a different virtual address than the
+ address it was linked at.
+ Since RISCV uses the RELA relocation format, this requires a
+ relocation pass at runtime even if the kernel is loaded at the
+ same address it was linked at.
+
endmenu
menu "Boot options"
--
2.33.0.1079.g6e70778dc9-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] RISC-V: Make CONFIG_RELOCATABLE user selectable
2021-10-26 21:28 [PATCH] RISC-V: Make CONFIG_RELOCATABLE user selectable Palmer Dabbelt
@ 2021-10-27 5:07 ` Alexandre ghiti
2021-10-27 8:00 ` Andreas Schwab
1 sibling, 0 replies; 6+ messages in thread
From: Alexandre ghiti @ 2021-10-27 5:07 UTC (permalink / raw)
To: Palmer Dabbelt
Cc: Paul Walmsley, aou, linux-riscv, linux-kernel, kernel-team,
Palmer Dabbelt
Hi Palmer,
On 10/26/21 11:28 PM, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmerdabbelt@google.com>
>
> This should really be up to the user, as it trades off portability for
> performance.
>
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
> ---
> arch/riscv/Kconfig | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 5dea03549493..f8a36034d54b 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -212,18 +212,6 @@ config PGTABLE_LEVELS
> config LOCKDEP_SUPPORT
> def_bool y
>
> -config RELOCATABLE
> - bool
> - depends on MMU && 64BIT && !XIP_KERNEL
> - help
> - This builds a kernel as a Position Independent Executable (PIE),
> - which retains all relocation metadata required to relocate the
> - kernel binary at runtime to a different virtual address than the
> - address it was linked at.
> - Since RISCV uses the RELA relocation format, this requires a
> - relocation pass at runtime even if the kernel is loaded at the
> - same address it was linked at.
> -
> source "arch/riscv/Kconfig.socs"
> source "arch/riscv/Kconfig.erratas"
>
> @@ -433,6 +421,18 @@ config CRASH_DUMP
>
> For more details see Documentation/admin-guide/kdump/kdump.rst
>
> +config RELOCATABLE
> + bool "Build a relocatable kernel"
> + depends on MMU && 64BIT && !XIP_KERNEL
> + help
> + This builds a kernel as a Position Independent Executable (PIE),
> + which retains all relocation metadata required to relocate the
> + kernel binary at runtime to a different virtual address than the
> + address it was linked at.
> + Since RISCV uses the RELA relocation format, this requires a
> + relocation pass at runtime even if the kernel is loaded at the
> + same address it was linked at.
> +
> endmenu
>
> menu "Boot options"
Agreed, you can add:
Reviewed-by: Alexandre Ghiti <alexandre.ghiti@canonical.com>
Thanks for the patch,
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RISC-V: Make CONFIG_RELOCATABLE user selectable
2021-10-26 21:28 [PATCH] RISC-V: Make CONFIG_RELOCATABLE user selectable Palmer Dabbelt
2021-10-27 5:07 ` Alexandre ghiti
@ 2021-10-27 8:00 ` Andreas Schwab
2021-10-27 8:58 ` Alexandre Ghiti
1 sibling, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2021-10-27 8:00 UTC (permalink / raw)
To: Palmer Dabbelt
Cc: alex, Paul Walmsley, aou, linux-riscv, linux-kernel, kernel-team,
Palmer Dabbelt
On Okt 26 2021, Palmer Dabbelt wrote:
> +config RELOCATABLE
> + bool "Build a relocatable kernel"
> + depends on MMU && 64BIT && !XIP_KERNEL
> + help
> + This builds a kernel as a Position Independent Executable (PIE),
> + which retains all relocation metadata required to relocate the
> + kernel binary at runtime to a different virtual address than the
> + address it was linked at.
> + Since RISCV uses the RELA relocation format, this requires a
> + relocation pass at runtime even if the kernel is loaded at the
> + same address it was linked at.
When in doubt, do what?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RISC-V: Make CONFIG_RELOCATABLE user selectable
2021-10-27 8:00 ` Andreas Schwab
@ 2021-10-27 8:58 ` Alexandre Ghiti
2021-10-27 9:45 ` Andreas Schwab
0 siblings, 1 reply; 6+ messages in thread
From: Alexandre Ghiti @ 2021-10-27 8:58 UTC (permalink / raw)
To: Andreas Schwab
Cc: Palmer Dabbelt, alex, Paul Walmsley, aou, linux-riscv,
linux-kernel, kernel-team, Palmer Dabbelt
On Wed, Oct 27, 2021 at 10:03 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Okt 26 2021, Palmer Dabbelt wrote:
>
> > +config RELOCATABLE
> > + bool "Build a relocatable kernel"
> > + depends on MMU && 64BIT && !XIP_KERNEL
> > + help
> > + This builds a kernel as a Position Independent Executable (PIE),
> > + which retains all relocation metadata required to relocate the
> > + kernel binary at runtime to a different virtual address than the
> > + address it was linked at.
> > + Since RISCV uses the RELA relocation format, this requires a
> > + relocation pass at runtime even if the kernel is loaded at the
> > + same address it was linked at.
>
> When in doubt, do what?
Then do not enable. it will be automatically selected by other configs
like KASLR, but otherwise you should not say yes since you'll just
have an identical slightly slower kernel.
But I imagine you mean adding a default value for this config? That
sounds right and it should be "default n".
Alex
>
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
> "And now for something completely different."
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RISC-V: Make CONFIG_RELOCATABLE user selectable
2021-10-27 8:58 ` Alexandre Ghiti
@ 2021-10-27 9:45 ` Andreas Schwab
2021-10-27 23:09 ` Palmer Dabbelt
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2021-10-27 9:45 UTC (permalink / raw)
To: Alexandre Ghiti
Cc: Palmer Dabbelt, alex, Paul Walmsley, aou, linux-riscv,
linux-kernel, kernel-team, Palmer Dabbelt
On Okt 27 2021, Alexandre Ghiti wrote:
> On Wed, Oct 27, 2021 at 10:03 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>>
>> On Okt 26 2021, Palmer Dabbelt wrote:
>>
>> > +config RELOCATABLE
>> > + bool "Build a relocatable kernel"
>> > + depends on MMU && 64BIT && !XIP_KERNEL
>> > + help
>> > + This builds a kernel as a Position Independent Executable (PIE),
>> > + which retains all relocation metadata required to relocate the
>> > + kernel binary at runtime to a different virtual address than the
>> > + address it was linked at.
>> > + Since RISCV uses the RELA relocation format, this requires a
>> > + relocation pass at runtime even if the kernel is loaded at the
>> > + same address it was linked at.
>>
>> When in doubt, do what?
>
> Then do not enable.
Please add that to the help string.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RISC-V: Make CONFIG_RELOCATABLE user selectable
2021-10-27 9:45 ` Andreas Schwab
@ 2021-10-27 23:09 ` Palmer Dabbelt
0 siblings, 0 replies; 6+ messages in thread
From: Palmer Dabbelt @ 2021-10-27 23:09 UTC (permalink / raw)
To: schwab
Cc: alexandre.ghiti, alex, Paul Walmsley, aou, linux-riscv,
linux-kernel, kernel-team
On Wed, 27 Oct 2021 02:45:27 PDT (-0700), schwab@linux-m68k.org wrote:
> On Okt 27 2021, Alexandre Ghiti wrote:
>
>> On Wed, Oct 27, 2021 at 10:03 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>>>
>>> On Okt 26 2021, Palmer Dabbelt wrote:
>>>
>>> > +config RELOCATABLE
>>> > + bool "Build a relocatable kernel"
>>> > + depends on MMU && 64BIT && !XIP_KERNEL
>>> > + help
>>> > + This builds a kernel as a Position Independent Executable (PIE),
>>> > + which retains all relocation metadata required to relocate the
>>> > + kernel binary at runtime to a different virtual address than the
>>> > + address it was linked at.
>>> > + Since RISCV uses the RELA relocation format, this requires a
>>> > + relocation pass at runtime even if the kernel is loaded at the
>>> > + same address it was linked at.
>>>
>>> When in doubt, do what?
>>
>> Then do not enable.
>
> Please add that to the help string.
Thanks, I forgot about that. I've added it, but this is still a bit in
flux so I'm not going to send a v2 right now (it's on top of Alex's
other patches and should probably be squashed in, anyway).
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-27 23:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-26 21:28 [PATCH] RISC-V: Make CONFIG_RELOCATABLE user selectable Palmer Dabbelt
2021-10-27 5:07 ` Alexandre ghiti
2021-10-27 8:00 ` Andreas Schwab
2021-10-27 8:58 ` Alexandre Ghiti
2021-10-27 9:45 ` Andreas Schwab
2021-10-27 23:09 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox