From: Felipe Balbi <balbi@kernel.org>
To: Michael Grzeschik <mgr@pengutronix.de>
Cc: Ferry Toth <fntoth@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] usb: dwc3: gadget: Revert "set gadgets parent to the right controller"
Date: Tue, 05 Oct 2021 13:49:32 +0300 [thread overview]
Message-ID: <87ee8zzqxr.fsf@kernel.org> (raw)
In-Reply-To: <20211005085100.GB17524@pengutronix.de>
Michael Grzeschik <mgr@pengutronix.de> writes:
> [[PGP Signed Part:Undecided]]
> On Mon, Oct 04, 2021 at 10:35:57PM +0200, Ferry Toth wrote:
>>Hi,
>>
>>Op 04-10-2021 om 16:18 schreef Andy Shevchenko:
>>>The commit c6e23b89a95d ("usb: dwc3: gadget: set gadgets parent to the right
>>>controller") changed the device for the UDC and broke the user space scripts
>>>that instantiate the USB gadget(s) via ConfigFS.
>>
>> I confirm this regression on Intel Edison since at least 5.15-rc2
>> while in 5.14.0 it was working fine.
>>
>>This patch resolves the issue as tested on 5.15-rc4.
>>
>>Tested-by: Ferry Toth<fntoth@gmail.com>
>
> NACK! Why should we resolv an issue by reverting it to solve not working
> userspace. We already have this patch as a solution for solving a deeper
heh, there is only one rule in this community: thou shalt not break
userspace :-)
--
balbi
next prev parent reply other threads:[~2021-10-05 10:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 14:18 [PATCH v1 1/1] usb: dwc3: gadget: Revert "set gadgets parent to the right controller" Andy Shevchenko
2021-10-04 20:35 ` Ferry Toth
2021-10-05 8:51 ` Michael Grzeschik
2021-10-05 9:17 ` Andy Shevchenko
2021-10-05 10:49 ` Felipe Balbi [this message]
2021-10-05 11:04 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee8zzqxr.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=fntoth@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mgr@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox