Re: [PATCH v2] usb: cdns3: Add streams support to cadence USB3 DRD driver

Felipe Balbi
2020-01-15T09:06:33Z

[-- Attachment #1: Type: text/plain, Size: 1695 bytes --]

Hi,

Jayshri Pawar <jpawar@cadence.com> writes:
> This patch includes streams implementation changes.
> The current changes has been validated on FPGA platform.
>
> Enabled streams related interrupts only for streams capable endpoints.
> Processed PRIME and IOT interrupts related to streams capable endpoints.
> Based on PRIME interrupt prime_flag is set and transfer is armed
> otherwise just adding request to the deferred request queue.
> For streams capable endpoints preparing TD with correct stream ID.
>
> TDL calculation:
> Updated tdl calculation based on controller versions.
> 1. For controller version DEV_VER_V2 :We have enabled USB_CONF2_EN_TDL_TRB
> bit in usb_conf2 register in DMULT configuration.
> This enables TDL calculation based on TRB, hence setting TDL in TRB.
> 2. For controller Version < DEV_VER_V2 : Writing TDL and STDL in ep_cmd
> register
> 3. For controller version > DEV_VER_V2 : Writing TDL in ep_tdl register.

> Writing ERDY with correct Stream ID to ep_cmd register.
> Added stream id related information to trace logs.
>
> Signed-off-by: Jayshri Pawar <jpawar@cadence.com>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> Signed-off-by: Rahul Kumar <kurahul@cadence.com>
> ---
>
> Version History:
> v2: Patch generated on top of linux-next.git master branch
>
> drivers/usb/cdns3/gadget.c | 533 +++++++++++++++++++++++++++++++++----
> drivers/usb/cdns3/gadget.h | 26 +-
> drivers/usb/cdns3/trace.h | 93 ++++++-
> 3 files changed, 596 insertions(+), 56 deletions(-)

This patch is enormous. Are you sure there's no way to break it down
into smaller pieces?

(Hint: there is)

--
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]