From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: Move page table dump files in a dedicated subdirectory
Date: Thu, 21 Feb 2019 20:12:26 +1100 [thread overview]
Message-ID: <87ef81wlmt.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <0f371616-0ab6-fe96-852a-323159c58572@c-s.fr>
Christophe Leroy <christophe.leroy@c-s.fr> writes:
> Le 20/02/2019 à 14:37, Michael Ellerman a écrit :
>> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>>
>>> This patch moves the files related to page table dump in a
>>> dedicated subdirectory.
>>>
>>> The purpose is to clean a bit arch/powerpc/mm by regrouping
>>> multiple files handling a dedicated function.
>>>
>>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>>> ---
>>> arch/powerpc/Kconfig.debug | 4 ----
>>> arch/powerpc/mm/Makefile | 10 +---------
>>> arch/powerpc/mm/ptdump/Makefile | 9 +++++++++
>>> arch/powerpc/mm/{ => ptdump}/dump_bats.c | 0
>>> arch/powerpc/mm/{ => ptdump}/dump_hashpagetable.c | 0
>>> arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-8xx.c | 0
>>> arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-book3s64.c | 0
>>> arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-generic.c | 0
>>> arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables.c | 0
>>> arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables.h | 0
>>> arch/powerpc/mm/{ => ptdump}/dump_sr.c | 0
>>> 11 files changed, 10 insertions(+), 13 deletions(-)
>>> create mode 100644 arch/powerpc/mm/ptdump/Makefile
>>> rename arch/powerpc/mm/{ => ptdump}/dump_bats.c (100%)
>>> rename arch/powerpc/mm/{ => ptdump}/dump_hashpagetable.c (100%)
>>> rename arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-8xx.c (100%)
>>> rename arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-book3s64.c (100%)
>>> rename arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-generic.c (100%)
>>> rename arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables.c (100%)
>>> rename arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables.h (100%)
>>> rename arch/powerpc/mm/{ => ptdump}/dump_sr.c (100%)
>>
>> I'd like to shorten the file names as well, now that they're namespaced
>> in the ptdump directory, how about:
>>
>> arch/powerpc/Kconfig.debug | 4 ----
>> arch/powerpc/mm/Makefile | 10 +---------
>> arch/powerpc/mm/{dump_linuxpagetables-8xx.c => ptdump/8xx.c} | 2 +-
>> arch/powerpc/mm/ptdump/Makefile | 9 +++++++++
>> arch/powerpc/mm/{dump_bats.c => ptdump/bats.c} | 0
>> arch/powerpc/mm/{dump_linuxpagetables-book3s64.c => ptdump/book3s64.c} | 2 +-
>> arch/powerpc/mm/{dump_hashpagetable.c => ptdump/hashpagetable.c} | 0
>> arch/powerpc/mm/{dump_linuxpagetables.c => ptdump/ptdump.c} | 2 +-
>> arch/powerpc/mm/{dump_linuxpagetables.h => ptdump/ptdump.h} | 0
>> arch/powerpc/mm/{dump_sr.c => ptdump/segment_regs.c} | 0
>> arch/powerpc/mm/{dump_linuxpagetables-generic.c => ptdump/shared.c} | 2 +-
>
> Yes good idea. Do you want a v2 or will you do it ?
I'll do it, thanks.
cheers
next prev parent reply other threads:[~2019-02-21 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 12:28 [PATCH] powerpc: Move page table dump files in a dedicated subdirectory Christophe Leroy
2019-02-20 13:37 ` Michael Ellerman
2019-02-20 14:00 ` Christophe Leroy
2019-02-21 9:12 ` Michael Ellerman [this message]
2019-02-22 9:48 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef81wlmt.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox