From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 422F7C6778A for ; Sun, 22 Jul 2018 14:11:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E1E1620858 for ; Sun, 22 Jul 2018 14:11:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1E1620858 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=users.sourceforge.jp Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729584AbeGVPHv (ORCPT ); Sun, 22 Jul 2018 11:07:51 -0400 Received: from mail01.asahi-net.or.jp ([202.224.55.13]:39723 "EHLO mail01.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728549AbeGVPHv (ORCPT ); Sun, 22 Jul 2018 11:07:51 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.vps.ablenet.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail01.asahi-net.or.jp (Postfix) with ESMTPA id F0DAC81AEF; Sun, 22 Jul 2018 23:11:00 +0900 (JST) Received: from yo-satoh-debian.ysato.ml (ZM028236.ppp.dion.ne.jp [222.8.28.236]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id B0843240070; Sun, 22 Jul 2018 23:11:00 +0900 (JST) Date: Sun, 22 Jul 2018 23:11:00 +0900 Message-ID: <87effvfjij.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Rob Herring Cc: linux-kernel@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp Subject: Re: [PATCH] h8300: remove unnecessary of_platform_populate call In-Reply-To: <20180619214054.19326-1-robh@kernel.org> References: <20180619214054.19326-1-robh@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Jun 2018 06:40:54 +0900, Rob Herring wrote: > > The DT core will call of_platform_populate, so it is not necessary for > arch specific code to call it unless there are custom match entries, > auxdata or parent device. Neither of those apply here, so remove the call. > > Cc: Yoshinori Sato > Cc: uclinux-h8-devel@lists.sourceforge.jp > Signed-off-by: Rob Herring > --- > arch/h8300/kernel/setup.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c > index a4d0470c10a9..b2b51f75774e 100644 > --- a/arch/h8300/kernel/setup.c > +++ b/arch/h8300/kernel/setup.c > @@ -23,7 +23,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -188,15 +187,6 @@ const struct seq_operations cpuinfo_op = { > .show = show_cpuinfo, > }; > > -static int __init device_probe(void) > -{ > - of_platform_populate(NULL, NULL, NULL, NULL); > - > - return 0; > -} > - > -device_initcall(device_probe); > - > #if defined(CONFIG_CPU_H8300H) > #define get_wait(base, addr) ({ \ > int baddr; \ > -- > 2.17.1 > Sorry. too late reply. Applied to h8300-next. Thanks. -- Yosinori Sato