From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753855AbdEQUDy (ORCPT ); Wed, 17 May 2017 16:03:54 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:42769 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbdEQUDw (ORCPT ); Wed, 17 May 2017 16:03:52 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Al Viro Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Ingo Molnar , Oleg Nesterov , Peter Zijlstra , Christoph Hellwig References: <20170515223157.GM390@ZenIV.linux.org.uk> Date: Wed, 17 May 2017 14:57:13 -0500 In-Reply-To: <20170515223157.GM390@ZenIV.linux.org.uk> (Al Viro's message of "Mon, 15 May 2017 23:31:57 +0100") Message-ID: <87efvn9rza.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1dB5Ac-0004c5-9W;;;mid=<87efvn9rza.fsf@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=97.121.81.159;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18lJrbl3h55FxGhtDn3wtwJhqV/OE/BSE4= X-SA-Exim-Connect-IP: 97.121.81.159 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 1.5 TR_Symld_Words too many words that have symbols inside * 0.0 TVD_RCVD_IP Message was received from an IP address * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4980] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa02 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_02 5+ unique symbols in subject * 0.0 T_TooManySym_01 4+ unique symbols in subject * 1.0 T_XMDrugObfuBody_08 obfuscated drug references X-Spam-DCC: XMission; sa02 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;Al Viro X-Spam-Relay-Country: X-Spam-Timing: total 5419 ms - load_scoreonly_sql: 0.08 (0.0%), signal_user_changed: 6 (0.1%), b_tie_ro: 3.6 (0.1%), parse: 1.19 (0.0%), extract_message_metadata: 121 (2.2%), get_uri_detail_list: 1.79 (0.0%), tests_pri_-1000: 64 (1.2%), tests_pri_-950: 22 (0.4%), tests_pri_-900: 1.79 (0.0%), tests_pri_-400: 84 (1.5%), check_bayes: 81 (1.5%), b_tokenize: 25 (0.5%), b_tok_get_all: 14 (0.3%), b_comp_prob: 3.4 (0.1%), b_tok_touch_all: 20 (0.4%), b_finish: 0.79 (0.0%), tests_pri_0: 1556 (28.7%), check_dkim_signature: 0.99 (0.0%), check_dkim_adsp: 9 (0.2%), tests_pri_500: 3549 (65.5%), poll_dns_idle: 3539 (65.3%), rewrite_mail: 0.00 (0.0%) Subject: Re: [RFC][PATCHSET] wait4()/waitid() cleanups X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Al Viro writes: > This series switches compat wait4() and waitid() variants away > from set_fs() use. A couple of helpers (kernel_wait4() and kernel_waitid()) > are introduced, copying siginfo/rusage to userland is taken to sys_wait...(). > That allows both to simplify the guts of do_wait() machinery and avoid > messing with set_fs() in compat variants of these syscalls. > > Lightly tested, seems to survive without regressions. Please, > review. A quick heads up. I have a patchset that is almost ready to go that is also extensively touching wait. The point of that patchset is to get the logic correct in the intersection ptrace, threads, signals, and wait. As an example of things that are obviously wrong today. In the case of a ptrace stop we can set si_code to either CLD_STOPPED or CLD_TRAPPED but in waitid we always return for the same set of conditions CLD_TRAPPED. I don't believe we have any fundamental conflicts but if we aren't careful we could have a nasty merge conflict. Eric