From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754192AbdBPKCM (ORCPT ); Thu, 16 Feb 2017 05:02:12 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:55502 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753974AbdBPKCG (ORCPT ); Thu, 16 Feb 2017 05:02:06 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E5626607BC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Arend Van Spriel Cc: =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Randy Dunlap , kbuild test robot , kbuild-all@01.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init' References: <201702071839.Ej9MjmlI%fengguang.wu@intel.com> <87inoamqh6.fsf@kamboji.qca.qualcomm.com> <59013c13-af43-cf9f-8e3e-14d97e48f0dd@broadcom.com> Date: Thu, 16 Feb 2017 12:01:49 +0200 In-Reply-To: <59013c13-af43-cf9f-8e3e-14d97e48f0dd@broadcom.com> (Arend Van Spriel's message of "Thu, 16 Feb 2017 10:53:02 +0100") Message-ID: <87efyymp2q.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1GA2Wfi021609 Arend Van Spriel writes: > On 16-2-2017 10:39, Rafał Miłecki wrote: >> On 02/16/2017 10:31 AM, Kalle Valo wrote: >>> (Adding linux-wireless) >>> >>> Randy Dunlap writes: >>> >>>> On 02/07/17 02:02, kbuild test robot wrote: >>>>> Hi Kalle, >>>>> >>>>> FYI, the error/warning still remains. >>>>> >>>>> tree: >>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >>>>> master >>>>> head: 8b1b41ee74f9712c355d66dc105bbea663ae0afd >>>>> commit: 05491d2ccf20b20a1375303441fbbfbd12b24a4f brcm80211: move >>>>> under broadcom vendor directory >>>>> date: 1 year, 3 months ago >>>>> config: mips-allyesconfig (attached as .config) >>>>> compiler: mips-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 >>>>> reproduce: >>>>> wget >>>>> https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross >>>>> >>>>> -O ~/bin/make.cross >>>>> chmod +x ~/bin/make.cross >>>>> git checkout 05491d2ccf20b20a1375303441fbbfbd12b24a4f >>>>> # save the attached .config to linux build tree >>>>> make.cross ARCH=mips >>>>> >>>>> All errors (new ones prefixed by >>): n>>>> >>>> when both: >>>> >>>> CONFIG_BRCM_TRACING=y >>>> CONFIG_BRCMDBG=y >>>> >>>> but DEBUG is not defined. >>>> >>>> I think it would help if CONFIG_BRCMDBG set DEBUG >>>> or if some of the tests for DEBUG used CONFIG_BRCMDBG instead. >>> >>> Arend or Rafał, would you be able to look at this build problem? Kbuild >>> found the build errors below, apparently a very old issue. It just >>> blames me now because I moved the driver to a new directory :) > > It is a very old issue. The thing is that the issue can not really occur > because we have this: > > # common flags > subdir-ccflags-$(CONFIG_BRCMDBG) += -DDEBUG > > in drivers/net/wireless/broadcom/brcm80211/Makefile. So no clue what > happens in the "kbuild test robot" scenario. I actually tried to reproduce this with kbuild bot's instructions and was surprised to see that the build worked ok for me. So the issue is not that simple. -- Kalle Valo