From: Andi Kleen <andi@firstfloor.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, vince@deater.net,
eranian@google.com, Arnaldo Carvalho de Melo <acme@infradead.org>,
Borislav Petkov <bp@suse.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] perf/x86/intel/pt: Allow disabling branch tracing
Date: Mon, 06 Feb 2017 07:58:25 -0800 [thread overview]
Message-ID: <87efzbjopq.fsf@firstfloor.org> (raw)
In-Reply-To: <20170206144140.14402-1-alexander.shishkin@linux.intel.com> (Alexander Shishkin's message of "Mon, 6 Feb 2017 16:41:40 +0200")
Alexander Shishkin <alexander.shishkin@linux.intel.com> writes:
> Now that Intel PT supports more types of trace content than just branch
> tracing, it may be useful to allow the user to disable branch tracing
> when it is not needed.
>
> The special case is BDW, where not setting BranchEn is not supported.
>
> This is slightly trickier than necessary, because up to this moment
> the driver has been setting BranchEn automatically and the userspace
> assumes as much. Instead of reversing the semantics of BranchEn, we
> introduce a 'passthrough' bit, which will forego the default and allow
> the user to set BranchEn to their heart's content.
cpu/passthrough=1,branchen=1/ seems far uglier/more complicanted to me
than the original cpu/nobranch=1/
Just think how you would explain it to the user in the manpage.
-Andi
next prev parent reply other threads:[~2017-02-06 15:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 15:16 [PATCH 0/2] perf/x86/intel/pt: Misc updates Alexander Shishkin
2017-01-27 15:16 ` [PATCH 1/2] perf/x86/intel/pt: Add format strings for PTWRITE and power event tracing Alexander Shishkin
2017-02-01 10:21 ` [tip:perf/core] " tip-bot for Alexander Shishkin
2017-01-27 15:16 ` [PATCH 2/2] perf/x86/intel/pt: Allow disabling branch tracing Alexander Shishkin
2017-02-01 10:17 ` Ingo Molnar
2017-02-01 16:49 ` Alexander Shishkin
2017-02-02 10:14 ` Alexander Shishkin
2017-02-06 14:41 ` [PATCH] " Alexander Shishkin
2017-02-06 15:58 ` Andi Kleen [this message]
2017-02-06 16:05 ` Alexander Shishkin
2017-02-06 17:19 ` Andi Kleen
2017-04-27 8:11 ` Adrian Hunter
2017-03-30 8:33 ` [tip:perf/core] perf/x86/intel/pt: Allow the disabling of " tip-bot for Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efzbjopq.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@suse.de \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox