From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: daniel@zonque.org, haojian.zhuang@gmail.com,
linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions
Date: Sat, 10 Dec 2016 10:19:07 +0100 [thread overview]
Message-ID: <87eg1g16r8.fsf@belgarion.home> (raw)
In-Reply-To: <1481207730-6332-1-git-send-email-arvind.yadav.cs@gmail.com> (Arvind Yadav's message of "Thu, 8 Dec 2016 20:05:30 +0530")
Arvind Yadav <arvind.yadav.cs@gmail.com> writes:
Hi Arvind,
> In functions pxa2xx_build_functions, the memory allocated for
> 'functions' is live within the function only. After the
> allocation it is immediately freed with devm_kfree. There is
> no need to allocate memory for 'functions' with devm function
> so replace devm_kcalloc with kcalloc and devm_kfree with kfree.
That's not very true : the "need" is to spare the "manual" kfree you're adding
in your patch for one, and make it consistent with pxa2xx_build_groups() and
pxa2xx_build_state() for two.
Therefore I'm not very thrilled by this patch and unless it fixes a defect in
the driver I'd rather not have it in.
Cheers.
--
Robert
next prev parent reply other threads:[~2016-12-10 9:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 14:35 [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions Arvind Yadav
2016-12-08 15:20 ` Robin Murphy
2016-12-08 15:25 ` Robin Murphy
2016-12-10 9:19 ` Robert Jarzmik [this message]
2016-12-11 8:04 ` arvind Yadav
2016-12-27 12:49 ` Linus Walleij
2016-12-29 7:20 ` Robert Jarzmik
2016-12-30 13:02 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg1g16r8.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=arvind.yadav.cs@gmail.com \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox