From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
Alessio Igor Bogani <alessio.bogani@elettra.eu>,
Scott Wood <oss@buserror.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
LKML <linux-kernel@vger.kernel.org>,
linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org,
antoine.blangy@c-s.fr, segher@kernel.crashing.org
Subject: Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic()
Date: Fri, 05 Aug 2016 19:38:23 +1000 [thread overview]
Message-ID: <87eg63imi8.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <ab39b1b1-2320-31ba-3f19-11a62e3586b8@c-s.fr>
Christophe Leroy <christophe.leroy@c-s.fr> writes:
> Le 05/08/2016 à 08:57, Michael Ellerman a écrit :
>> Alessio Igor Bogani <alessio.bogani@elettra.eu> writes:
>>> On 4 August 2016 at 05:53, Scott Wood <oss@buserror.net> wrote:
>>>> On Tue, 2016-08-02 at 10:07 +0200, Christophe Leroy wrote:
>>>>> commit 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic()
>>>>> based on copy_tofrom_user()") introduced a bug when destination
>>>>> address is odd and initial csum is not null
>>>>>
>
> The purpose of this patch was not to address Alessio's issue, but to fix
> a huge issue on checksum calculation which induces breakdown of TCP
> connections.
>
> I think it is worth commiting it upstream and on impacted stable
> releases, allthought we don't have yet identified the issue Alessio's has.
OK. I'll put it back into fixes on Monday if I haven't heard anything
further.
cheers
next prev parent reply other threads:[~2016-08-05 9:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 8:07 [PATCH v2] powerpc/32: fix csum_partial_copy_generic() Christophe Leroy
2016-08-02 12:41 ` Segher Boessenkool
2016-08-02 12:51 ` Segher Boessenkool
2016-08-04 3:53 ` Scott Wood
2016-08-04 6:15 ` Alessio Igor Bogani
2016-08-05 6:57 ` Michael Ellerman
2016-08-05 7:26 ` Christophe Leroy
2016-08-05 9:38 ` Michael Ellerman [this message]
2016-08-10 12:46 ` [v2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg63imi8.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=alessio.bogani@elettra.eu \
--cc=antoine.blangy@c-s.fr \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox