From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751892AbcFVLRT (ORCPT ); Wed, 22 Jun 2016 07:17:19 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:49400 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751244AbcFVLRQ (ORCPT ); Wed, 22 Jun 2016 07:17:16 -0400 From: Kalle Valo To: Prasun Maiti Cc: Amitkumar Karwar , Nishant Sarmukadam , Linux Wireless , Linux Next , Linux Kernel Subject: Re: [PATCH] mwifiex: Reduce endian conversion for REG Host Commands References: <201606220027.euqOehrM%fengguang.wu@intel.com> <1466591125-32128-1-git-send-email-prasunmaiti87@gmail.com> Date: Wed, 22 Jun 2016 13:51:47 +0300 In-Reply-To: <1466591125-32128-1-git-send-email-prasunmaiti87@gmail.com> (Prasun Maiti's message of "Wed, 22 Jun 2016 15:55:25 +0530") Message-ID: <87eg7ph4xo.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Prasun Maiti writes: > For multiple REG Host Commands (e.g HostCmd_CMD_802_11_EEPROM_ACCESS, > HostCmd_CMD_MAC_REG_ACCESS etc.) "cpu_to_leX"-converted values are > saved to driver. So, "leX_to_cpu" conversion is required too many > times afterwards in driver. > > This patch reduces the endian: conversion without saving "cpu_to_leX" > converted values in driver. This will convert endianness in prepare > command and command response path. > > Signed-off-by: Prasun Maiti If you send a new version of the patch mark it as [PATCH v2] and always include a change log so that people don't need to guess what has changed: http://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb So now you should send a v3 and include a changelog. -- Kalle Valo