From: Felipe Balbi <balbi@kernel.org>
To: Roger Quadros <rogerq@ti.com>, grygorii.strashko@ti.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH] usb: dwc3: fix runtime PM in error path
Date: Fri, 10 Jun 2016 12:16:51 +0300 [thread overview]
Message-ID: <87eg85769o.fsf@linux.intel.com> (raw)
In-Reply-To: <1465548878-30085-1-git-send-email-rogerq@ti.com>
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
Hi,
Roger Quadros <rogerq@ti.com> writes:
> If there is a failure after pm_runtime_enable/get_sync()
> we need to call pm_runtime_disable/put_sync().
>
> Otherwise it will lead to an unbalanced pm_runtime_enable() on the
> subsequent probe if the earlier probe bailed out due to -EPROBE_DEFER.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
where is this supposed to be applied? You're not checking if
pm_runtime_get() failed at all.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-06-10 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 8:54 [PATCH] usb: dwc3: fix runtime PM in error path Roger Quadros
2016-06-10 9:16 ` Felipe Balbi [this message]
2016-06-10 9:52 ` Roger Quadros
2016-06-10 10:05 ` Felipe Balbi
2016-06-10 11:37 ` [PATCH v2] " Roger Quadros
2016-06-10 11:38 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg85769o.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox