From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755569AbcBPRXQ (ORCPT ); Tue, 16 Feb 2016 12:23:16 -0500 Received: from down.free-electrons.com ([37.187.137.238]:35890 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752271AbcBPRXN convert rfc822-to-8bit (ORCPT ); Tue, 16 Feb 2016 12:23:13 -0500 From: Gregory CLEMENT To: Jisheng Zhang Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , , Catalin Marinas , Will Deacon , Jonathan Corbet , Mark Rutland , , , Greg Kroah-Hartman , Omri Itach , , Nadav Haklai , "Hans de Goede" , Lior Amsalem , , Jiri Slaby , Tejun Heo , Thomas Petazzoni , Subject: Re: [PATCH v3 09/12] arm64: dts: add the Marvell Armada 3700 family and a development board References: <1454951660-13289-1-git-send-email-gregory.clement@free-electrons.com> <1454951660-13289-10-git-send-email-gregory.clement@free-electrons.com> <20160216141627.78ec94bd@xhacker> Date: Tue, 16 Feb 2016 18:02:05 +0100 In-Reply-To: <20160216141627.78ec94bd@xhacker> (Jisheng Zhang's message of "Tue, 16 Feb 2016 14:16:27 +0800") Message-ID: <87egcctwqa.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jisheng, On mar., févr. 16 2016, Jisheng Zhang wrote: > Dear Gregory, > On Mon, 8 Feb 2016 18:14:17 +0100 Gregory CLEMENT wrote: > >> Add initial dtsi files to support Marvell Armada 3700 SoC with Cortex-A53 >> CPUs. There are two members in this family: the Armada 3710 (Single CPU) >> and the Armada 3720 (Dual CPUs). >> >> It also adds a dts file for the Marvell Armada 3720 DB board. >> >> Signed-off-by: Gregory CLEMENT >> --- >> arch/arm64/boot/dts/marvell/Makefile | 4 + >> arch/arm64/boot/dts/marvell/armada-371x.dtsi | 53 ++++++++++ >> arch/arm64/boot/dts/marvell/armada-3720-db.dts | 86 ++++++++++++++++ >> arch/arm64/boot/dts/marvell/armada-372x.dtsi | 63 ++++++++++++ >> arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 131 +++++++++++++++++++++++++ >> 5 files changed, 337 insertions(+) >> create mode 100644 arch/arm64/boot/dts/marvell/armada-371x.dtsi >> create mode 100644 arch/arm64/boot/dts/marvell/armada-3720-db.dts >> create mode 100644 arch/arm64/boot/dts/marvell/armada-372x.dtsi >> create mode 100644 arch/arm64/boot/dts/marvell/armada-37xx.dtsi >> >> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile >> index 348f4db4f313..2114af8d312d 100644 >> --- a/arch/arm64/boot/dts/marvell/Makefile >> +++ b/arch/arm64/boot/dts/marvell/Makefile >> @@ -1,6 +1,10 @@ >> +# Berlin SoC Family >> dtb-$(CONFIG_ARCH_BERLIN) += berlin4ct-dmp.dtb >> dtb-$(CONFIG_ARCH_BERLIN) += berlin4ct-stb.dtb >> >> +# Mvebu SoC Family >> +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb >> + >> always := $(dtb-y) >> subdir-y := $(dts-dirs) >> clean-files := *.dtb >> diff --git a/arch/arm64/boot/dts/marvell/armada-371x.dtsi b/arch/arm64/boot/dts/marvell/armada-371x.dtsi >> new file mode 100644 >> index 000000000000..c9e5325b8ac3 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/marvell/armada-371x.dtsi >> @@ -0,0 +1,53 @@ >> +/* >> + * Device Tree Include file for Marvell Armada 371x family of SoCs >> + * (also named 88F3710) >> + * >> + * Copyright (C) 2016 Marvell > > Is it better to Add full Marvell company name, eg. Marvell Technology Group Ltd. > Well for mvebu I also saw "Marvell International Ltd." and "Marvell Semiconductors". So at least Marvell is the common pattern. >> + * >> + * Gregory CLEMENT > > What does this mean? in copyright holder list or just author? Is it better > to add "Author:" prefix or something else? > > I don't know the subtilitis between copyright holder list and author... > [...] > >> diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi >> new file mode 100644 >> index 000000000000..ba9df7ff2a72 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi >> @@ -0,0 +1,131 @@ >> +/* >> + * Device Tree Include file for Marvell Armada 37xx family of SoCs. >> + * >> + * Copyright (C) 2016 Marvell >> + * >> + * Gregory CLEMENT >> + * >> + * This file is dual-licensed: you can use it either under the terms >> + * of the GPL or the X11 license, at your option. Note that this dual >> + * licensing only applies to this file, and not this project as a >> + * whole. >> + * >> + * a) This file is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation; either version 2 of the >> + * License, or (at your option) any later version. >> + * >> + * This file is distributed in the hope that it will be useful >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * Or, alternatively >> + * >> + * b) Permission is hereby granted, free of charge, to any person >> + * obtaining a copy of this software and associated documentation >> + * files (the "Software"), to deal in the Software without >> + * restriction, including without limitation the rights to use >> + * copy, modify, merge, publish, distribute, sublicense, and/or >> + * sell copies of the Software, and to permit persons to whom the >> + * Software is furnished to do so, subject to the following >> + * conditions: >> + * >> + * The above copyright notice and this permission notice shall be >> + * included in all copies or substantial portions of the Software. >> + * >> + * THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >> + * OTHER DEALINGS IN THE SOFTWARE. >> + */ >> + >> +#include >> + >> +/ { >> + model = "Marvell Armada 37xx SoC"; >> + compatible = "marvell,armada3700"; >> + interrupt-parent = <&gic>; >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + aliases { >> + serial0 = &uart0; >> + }; >> + >> + cpus { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + cpu@0 { >> + device_type = "cpu"; >> + compatible = "arm,cortex-a53", "arm,armv8"; >> + reg = <0>; >> + enable-method = "psci"; >> + }; >> + }; >> + >> + psci { >> + compatible = "arm,psci-0.2"; >> + method = "smc"; >> + }; >> + >> + timer { >> + compatible = "arm,armv8-timer"; >> + interrupts = > + (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>, >> + > + (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>, >> + > + (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>, >> + > + (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>; >> + }; >> + >> + soc { >> + compatible = "simple-bus"; >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + >> + internal-regs { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + compatible = "simple-bus"; >> + /* 32M internal register @ 0xd000_0000 */ >> + ranges = <0x0 0x0 0xd0000000 0x2000000>; >> + >> + uart0: serial@12000 { >> + compatible = "marvell,armada-3700-uart"; >> + reg = <0x12000 0x400>; >> + interrupts = ; >> + status = "disabled"; >> + }; >> + >> + usb3@58000 { >> + compatible = "generic-xhci"; >> + reg = <0x58000 0x4000>; >> + interrupts = ; >> + status = "disabled"; >> + }; >> + >> + sata@e0000 { >> + compatible = "marvell,armada-3700-ahci"; >> + reg = <0xe0000 0x2000>; >> + interrupts = ; >> + status = "disabled"; >> + }; >> + >> + gic: interrupt-controller@1d00000 { >> + compatible = "arm,gic-v3"; >> + #interrupt-cells = <3>; >> + interrupt-controller; >> + reg = <0x1d00000 0x10000>, /* GICD */ >> + <0x1d40000 0x40000>; /* GICR */ > > There's no GICC, GICV, GICH? As far as I know, there is only GICD and GICR. Gregory > >> + }; >> + }; >> + }; >> +}; > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com