From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756487AbcA2P0L (ORCPT ); Fri, 29 Jan 2016 10:26:11 -0500 Received: from smtp08.smtpout.orange.fr ([80.12.242.130]:54969 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756396AbcA2P0J (ORCPT ); Fri, 29 Jan 2016 10:26:09 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Fri, 29 Jan 2016 16:26:07 +0100 X-ME-IP: 86.199.70.175 From: Robert Jarzmik To: Arnd Bergmann Cc: Felipe Balbi , Imre Kaloz , Krzysztof Halasa , Russell King , Daniel Mack , Haojian Zhuang , Felipe Balbi , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch References: <1453997722-3489596-1-git-send-email-arnd@arndb.de> <1453997843-3489728-1-git-send-email-arnd@arndb.de> <87vb6c7mug.fsf@belgarion.home> <2664702.bXd9nOWVFO@wuerfel> X-URL: http://belgarath.falguerolles.org/ Date: Fri, 29 Jan 2016 16:26:03 +0100 In-Reply-To: <2664702.bXd9nOWVFO@wuerfel> (Arnd Bergmann's message of "Fri, 29 Jan 2016 11:07:18 +0100") Message-ID: <87egd076gk.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > On Friday 29 January 2016 10:32:07 Robert Jarzmik wrote: >> > This addresses both issues by moving all the definitions into the >> > pxa25x_udc driver itself. It turns out the only difference between >> > them was 'UDCCS_IO_ROF', and that could well be a mistake when it >> > was incorrectly copied from pxa25x to ixp4xx. >> Hi Arnd, >> >> Is there a reason to have chosen to move into pxa25_udc.c instead of >> drivers/usb/gadget/udc/pxa25x_udc.h ? pxa27x_udc has a .h in the same directory >> with register definitions, hence the question. > > Yes: The register definitions are only used in a single .c file and > are not an interface between files, so it's better to have them in > the file that uses them. > > I could have continued the cleanup and moved the two headers into the > respective drivers as well, but I had to stop somewhere ;-) Fair enough. Acked-by: Robert Jarzmik Cheers. -- Robert