From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757559AbcAJUfC (ORCPT ); Sun, 10 Jan 2016 15:35:02 -0500 Received: from smtp04.smtpout.orange.fr ([80.12.242.126]:59487 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757266AbcAJUfA (ORCPT ); Sun, 10 Jan 2016 15:35:00 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sun, 10 Jan 2016 21:34:59 +0100 X-ME-IP: 92.149.187.47 From: Robert Jarzmik To: Brian Norris Cc: Ezequiel Garcia , David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug References: <1439323034-8820-1-git-send-email-robert.jarzmik@free.fr> <20160107000626.GS109450@google.com> X-URL: http://belgarath.falguerolles.org/ Date: Sun, 10 Jan 2016 21:34:58 +0100 In-Reply-To: <20160107000626.GS109450@google.com> (Brian Norris's message of "Wed, 6 Jan 2016 16:06:26 -0800") Message-ID: <87egdpdvgt.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Brian Norris writes: > On Tue, Aug 11, 2015 at 09:57:12PM +0200, Robert Jarzmik wrote: >> @@ -127,11 +127,23 @@ >> #define EXT_CMD_TYPE_MONO 0 /* Monolithic read/write */ >> >> /* macros for registers read/write */ >> -#define nand_writel(info, off, val) \ >> - writel_relaxed((val), (info)->mmio_base + (off)) >> - >> -#define nand_readl(info, off) \ >> - readl_relaxed((info)->mmio_base + (off)) >> +#define nand_writel(info, off, val) \ >> + do { \ >> + dev_vdbg(&info->pdev->dev, \ >> + "%s():%d nand_writel(0x%x, %s)\n", \ >> + __func__, __LINE__, (val), #off); \ > > The stringification of 'off' works for now, but I think that'd be a bit > restrictive in the future, if we ever want to (e.g.) do arithmetic to > compute the offset, like: > > nand_writel(info, SOME_REGISTER_MACRO + idx * 4, foo); > > You might be better off just printing the hex value of the offset. Sure. I can always have a post-processing script to recreate the register names. I'll post a v2 soon. Cheers. -- Robert