From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753732AbbLKOMx (ORCPT ); Fri, 11 Dec 2015 09:12:53 -0500 Received: from mga11.intel.com ([192.55.52.93]:35064 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbbLKOMw (ORCPT ); Fri, 11 Dec 2015 09:12:52 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,413,1444719600"; d="scan'208";a="869578917" From: Alexander Shishkin To: Mathieu Poirier , gregkh@linuxfoundation.org Cc: zhang.chunyan@linaro.org, mike.leach@arm.com, tor@ti.com, al.grant@arm.com, fainelli@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo Subject: Re: [PATCH V6 20/26] perf: changing pmu::setup_aux() parameter to include event In-Reply-To: <1449176702-13213-21-git-send-email-mathieu.poirier@linaro.org> References: <1449176702-13213-1-git-send-email-mathieu.poirier@linaro.org> <1449176702-13213-21-git-send-email-mathieu.poirier@linaro.org> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 11 Dec 2015 16:12:39 +0200 Message-ID: <87egetcbvs.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mathieu Poirier writes: > For Coresight ETMv3/4 tracers the event carries information > about trace modes such as user or kernel space tracing and > whether tracing is allowed when operating in secure mode. Ok, so it looks to me that what you're doing in your setup_aux with the event, you should rather be doing in pmu::event_init(), which takes event as a parameter and it even makes more sense semantically, because that bit is really configuring the parameters of tracing and not capturing, which setup_aux() is more about. And the above paragraph also sounds very much like it. Since in Coresight there is a very clear distinction between trace generation (sources) and capturing (sinks) it should also be possible to structure the code in such a way that the former are not as closely tied to the latter. Please correct me if I'm missing something. Regards, -- Alex