From: ebiederm@xmission.com (Eric W. Biederman)
To: David Rientjes <rientjes@google.com>
Cc: "Hongjie Fang (方洪杰)" <Hongjie.Fang@spreadtrum.com>,
"Michal Hocko" <mhocko@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: 答复: [PATCHv2 4.3-rc6] proc: fix convert from oom_score_adj to oom_adj
Date: Wed, 28 Oct 2015 22:47:47 -0500 [thread overview]
Message-ID: <87eggeuyho.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <alpine.DEB.2.10.1510281651350.15960@chino.kir.corp.google.com> (David Rientjes's message of "Wed, 28 Oct 2015 16:54:04 -0700 (PDT)")
David Rientjes <rientjes@google.com> writes:
> On Wed, 28 Oct 2015, Hongjie Fang (方洪杰) wrote:
>
>> Under a userspace perspective, get a different value than he wrote,
>> it must be confusing.
>>
>
> It's confusing, but with purpose: it shows there is no direct mapping
> between /proc/pid/oom_adj and /proc/pid/oom_score_adj.
> /proc/pid/oom_score_adj is the effective policy and has been for years.
> The value returned by /proc/pid/oom_adj demonstrates reality vs what is
> perceived and is a side-effect of integer division truncating the result
> in C.
>
> It's a bad situation, I agree, and we anticipated the complete removal of
> /proc/pid/oom_adj years ago since it has been deprecated for years. Maybe
> one day we can convince Linus that is possible, but until then we're stuck
> with it.
If you really want to remove /proc/pid/oom_adj start by placing it in a
Kconfig so people can make it go away.
Eric
next prev parent reply other threads:[~2015-10-29 3:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 6:49 [PATCHv2 4.3-rc6] proc: fix convert from oom_score_adj to oom_adj Hongjie Fang (方洪杰)
2015-10-22 9:47 ` Michal Hocko
2015-10-26 21:42 ` David Rientjes
2015-10-27 12:37 ` Michal Hocko
[not found] ` <5eff586de266418090f792077fcff993@SHMBX01.spreadtrum.com>
2015-10-28 23:54 ` 答复: " David Rientjes
2015-10-29 3:47 ` Eric W. Biederman [this message]
2015-11-01 4:30 ` David Rientjes
2015-10-29 17:04 ` Michal Hocko
2015-10-30 12:59 ` Michal Hocko
2015-10-30 14:46 ` Michal Hocko
2015-11-01 4:38 ` David Rientjes
2015-11-02 13:08 ` Michal Hocko
2015-11-02 17:18 ` Dave Jones
2015-11-02 20:24 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eggeuyho.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=Hongjie.Fang@spreadtrum.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox