From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756240AbbFRQ5G (ORCPT ); Thu, 18 Jun 2015 12:57:06 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:32828 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514AbbFRQ44 (ORCPT ); Thu, 18 Jun 2015 12:56:56 -0400 References: <1434609119-19680-1-git-send-email-jsitnicki@gmail.com> <20150618083018.GD11984@sudip-PC> From: Jakub Sitnicki To: Sudip Mukherjee Cc: Greg Kroah-Hartman , Larry Finger , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8188eu: kill unused hal_data_8188e::fw_ractrl flag In-reply-to: <20150618083018.GD11984@sudip-PC> Date: Thu, 18 Jun 2015 18:56:52 +0200 Message-ID: <87egl9550r.fsf@frog.home> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 18, 2015 at 10:30 AM CEST, Sudip Mukherjee wrote: > On Thu, Jun 18, 2015 at 08:31:59AM +0200, Jakub Sitnicki wrote: >> Flag is never set. Remove it and the code that is dead because of it. >> >> Signed-off-by: Jakub Sitnicki >> --- > >> >> diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c >> index 28b5e7b..710fdc3 100644 >> --- a/drivers/staging/rtl8188eu/hal/odm.c >> +++ b/drivers/staging/rtl8188eu/hal/odm.c >> @@ -1170,13 +1170,10 @@ void odm_RSSIMonitorCheckCE(struct odm_dm_struct *pDM_Odm) >> } >> >> for (i = 0; i < sta_cnt; i++) { >> - if (PWDB_rssi[i] != (0)) { >> - if (pHalData->fw_ractrl) { >> - /* Report every sta's RSSI to FW */ >> - } else { >> - ODM_RA_SetRSSI_8188E( >> - &(pHalData->odmpriv), (PWDB_rssi[i]&0xFF), (u8)((PWDB_rssi[i]>>16) & 0xFF)); >> - } >> + if (PWDB_rssi[i] != 0) { >> + ODM_RA_SetRSSI_8188E(&pHalData->odmpriv, >> + PWDB_rssi[i] & 0xFF, >> + (PWDB_rssi[i] >> 16) & 0xFF); > and you are also removing an extra unneeded () and a typecast. True. I could have mentioned that in the commit message as it was intentional. Thanks for reviewing it. Regards, Jakub