From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1761320AbbBIT4X (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Feb 2015 14:56:23 -0500
Received: from smtp06.smtpout.orange.fr ([80.12.242.128]:51583 "EHLO
	smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1760378AbbBIT4U (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Feb 2015 14:56:20 -0500
X-ME-Helo: beldin
X-ME-Date: Mon, 09 Feb 2015 20:56:19 +0100
X-ME-IP: 109.220.218.8
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] ARM: dts: pxa: add clocks
References: <1423312760-15871-1-git-send-email-robert.jarzmik@free.fr>
	<1423312760-15871-2-git-send-email-robert.jarzmik@free.fr>
	<54D60B79.5060206@cogentembedded.com> <87a90p9815.fsf@free.fr>
	<54D64BBE.9080704@cogentembedded.com>
X-URL: http://belgarath.falguerolles.org/
Date: Mon, 09 Feb 2015 20:56:12 +0100
In-Reply-To: <54D64BBE.9080704@cogentembedded.com> (Sergei Shtylyov's message
	of "Sat, 07 Feb 2015 20:30:38 +0300")
Message-ID: <87egpy7tb7.fsf@free.fr>
User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.92 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +		ffuart: uart@40100000 {
> +			clocks = <&pxa2xx_clks CLK_FFUART>;
> +		};
> +

After another thought about your "one line" node, I think this can be even
improved, so that :
 - uart clocks are put into pxa2xx.dtsi instead of pxa27x.dtsi
 - replace all pxa2xx_clks by clks
 - let pxa27x.dtsi, pxa3xx.dtsi declare the clks label

This way we'll have :
 - pxa2xx.dtsi
		ffuart: uart@40100000 {
                        compatible = ...
                        ...
			clocks = <&clks CLK_FFUART>;
		};
 - pxa27x.dtsi
                clks: pxa2xx_clks@41300004 {
                        compatible = "marvell,pxa270-clocks";
                        #clock-cells = <1>;
                        status = "okay";
                };
 - pxa3xx.dtsi
                clks: pxa3xx_clks@41300004 {
                        compatible = "marvell,pxa300-clocks";
                        #clock-cells = <1>;
                        status = "okay";
                };

Cheers.

-- 
Robert