[PATCH] .gitignore: ignore Module.symvers in all directories

[PATCH] .gitignore: ignore Module.symvers in all directories

[Zhao, Gang]

When using `make M=/path/to/driver modules` to build a module, file
Module.symvers will be created in that directory, so it's better to
ignore it in all directories.

Slightly reordered, let specific file names behind general ones.

Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Kyungsik Lee <kyungsik.lee@lge.com>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>
Signed-off-by: Zhao, Gang <gamerh2o@gmail.com>
---
 .gitignore | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.gitignore b/.gitignore
index 7e9932e..3aa8145 100644
--- a/.gitignore
+++ b/.gitignore
@@ -22,7 +22,6 @@
 *.lst
 *.symtypes
 *.order
-modules.builtin
 *.elf
 *.bin
 *.gz
@@ -33,6 +32,8 @@ modules.builtin
 *.lzo
 *.patch
 *.gcno
+modules.builtin
+Module.symvers
 
 #
 # Top-level generic files
@@ -44,7 +45,6 @@ modules.builtin
 /vmlinuz
 /System.map
 /Module.markers
-/Module.symvers
 
 #
 # Debian directory (make deb-pkg)
-- 
1.9.0

Re: [PATCH] .gitignore: ignore Module.symvers in all directories

[Michal Marek]

On Mon, Apr 14, 2014 at 02:56:15PM +0800, Zhao, Gang wrote:
> When using `make M=/path/to/driver modules` to build a module, file
> Module.symvers will be created in that directory, so it's better to
> ignore it in all directories.
> 
> Slightly reordered, let specific file names behind general ones.
> 
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Kyungsik Lee <kyungsik.lee@lge.com>
> Cc: Markus Trippelsdorf <markus@trippelsdorf.de>
> Signed-off-by: Zhao, Gang <gamerh2o@gmail.com>

Note that the easier way to build a subtree of the kernel source is

  make path/to/driver/

including the trailing /. But the M=... syntax seems so widespread that
I have to apply this.

BTW: there is really no need to CC the last N people who touched
such a trivial file :).

Michal

Re: [PATCH] .gitignore: ignore Module.symvers in all directories

[Zhao, Gang]

On Wed, 2014-04-16 at 23:08:26 +0200, Michal Marek wrote:
> On Mon, Apr 14, 2014 at 02:56:15PM +0800, Zhao, Gang wrote:
>> When using `make M=/path/to/driver modules` to build a module, file
>> Module.symvers will be created in that directory, so it's better to
>> ignore it in all directories.
>> 
>> Slightly reordered, let specific file names behind general ones.
>> 
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Kyungsik Lee <kyungsik.lee@lge.com>
>> Cc: Markus Trippelsdorf <markus@trippelsdorf.de>
>> Signed-off-by: Zhao, Gang <gamerh2o@gmail.com>
>
> Note that the easier way to build a subtree of the kernel source is
>
>   make path/to/driver/
>
Thanks for pointing out this.

> including the trailing /. But the M=... syntax seems so widespread that
> I have to apply this.
>
The M=... syntax is the first I learned to build a module. I think it's
popular because one can build out of tree drivers by using it(adding
C=...). As you said, it's better to use `make path/to/driver/` to build
in-tree drivers.

> BTW: there is really no need to CC the last N people who touched
> such a trivial file :).
>
./scripts/get_maintainer.pl doesn't return the maintainer of this
file. Maybe you can add this file to MAINTAINERS(telling you are the
maintainer), but it's really so trivial. :-)

> Michal