From: Namhyung Kim <namhyung@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] perf sort: Add 'addr' sort key
Date: Wed, 27 Mar 2013 15:12:34 +0900 [thread overview]
Message-ID: <87ehf1gylp.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20130326144023.GA1621@gmail.com> (Ingo Molnar's message of "Tue, 26 Mar 2013 15:40:23 +0100")
Hi Ingo,
On Tue, 26 Mar 2013 15:40:23 +0100, Ingo Molnar wrote:
> * Namhyung Kim <namhyung@kernel.org> wrote:
>
>> From: Namhyung Kim <namhyung.kim@lge.com>
>>
>> New addr sort key provides a way to sort the entries by the symbol
>> addresses.
>
> No objections from me - just wondering about the motivation: why would we
> want to sort by symbol address?
In fact, it came from bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=55561
>
> Perhaps to see the overhead layout/distribution within a DSO, to better
> cache-pack hot functions by placing them next to each other?
>
> Putting a short usecase into the changelog (or even better, the
> documentation) would be nice.
Well, I didn't thought it much, but yeah, aforementioned usecase looks
promising. Also it might be useful to find out which part is the
hotpath in a function if you have some really big functions (possibly
due to auto-inlining or something).
Arnaldo, do you have other usecase/scenario in mind?
Thanks,
Namhyung
next prev parent reply other threads:[~2013-03-27 6:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 12:11 [PATCH 1/3] perf sort: Add 'addr' sort key Namhyung Kim
2013-03-26 12:11 ` [PATCH 2/3] perf sort: Add 'addr_to/from' " Namhyung Kim
2013-03-26 12:11 ` [PATCH 3/3] perf report: Fix alignment of symbol column when -v is given Namhyung Kim
2013-03-26 14:40 ` [PATCH 1/3] perf sort: Add 'addr' sort key Ingo Molnar
2013-03-27 6:12 ` Namhyung Kim [this message]
2013-03-27 20:59 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehf1gylp.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox