From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Stephane Eranian <eranian@google.com>,
Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [PATCH 07/13] perf hist browser: Add support for event group view
Date: Wed, 16 Jan 2013 18:52:03 +0900 [thread overview]
Message-ID: <87ehhlmp4s.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20130115183226.GC5826@ghostprotocols.net> (Arnaldo Carvalho de Melo's message of "Tue, 15 Jan 2013 15:32:26 -0300")
On Tue, 15 Jan 2013 15:32:26 -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jan 15, 2013 at 04:31:51PM +0900, Namhyung Kim escreveu:
>> From: Namhyung Kim <namhyung.kim@lge.com>
>>
>> Show group members' overhead also when showing the leader's if event
>> group is enabled. Use macro for defining hpp functions which looks
>> almost identical.
>>
>> Also move coloring logic into the hpp function so that each value can
>> be colored independently.
>
> Just from reading the description: when we have this "Also do this extra
> thing" it smells like we need to break the patch in two... Can this be
> done?
Sure. I'll break it.
Thanks,
Namhyung
next prev parent reply other threads:[~2013-01-16 9:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 7:31 [PATCHSET 00/13] perf report: Add support for event group view (v8) Namhyung Kim
2013-01-15 7:31 ` [PATCH 01/13] perf tools: Keep group information Namhyung Kim
2013-01-15 7:31 ` [PATCH 02/13] perf tests: Add group test conditions Namhyung Kim
2013-01-15 7:31 ` [PATCH 03/13] perf header: Add HEADER_GROUP_DESC feature Namhyung Kim
2013-01-15 7:31 ` [PATCH 04/13] perf report: Make another loop for linking group hists Namhyung Kim
2013-01-15 7:31 ` [PATCH 05/13] perf hists: Resort hist entries using group members for output Namhyung Kim
2013-01-15 18:29 ` Arnaldo Carvalho de Melo
2013-01-16 9:20 ` Namhyung Kim
2013-01-15 7:31 ` [PATCH 06/13] perf ui/hist: Add support for event group view Namhyung Kim
2013-01-15 18:31 ` Arnaldo Carvalho de Melo
2013-01-16 9:22 ` Namhyung Kim
2013-01-16 18:14 ` Arnaldo Carvalho de Melo
2013-01-15 7:31 ` [PATCH 07/13] perf hist browser: " Namhyung Kim
2013-01-15 18:32 ` Arnaldo Carvalho de Melo
2013-01-16 9:52 ` Namhyung Kim [this message]
2013-01-15 7:31 ` [PATCH 08/13] perf gtk/browser: " Namhyung Kim
2013-01-15 18:34 ` Arnaldo Carvalho de Melo
2013-01-16 10:25 ` Namhyung Kim
2013-01-16 18:28 ` Arnaldo Carvalho de Melo
2013-01-22 5:58 ` Namhyung Kim
2013-01-23 17:59 ` Arnaldo Carvalho de Melo
2013-01-15 7:31 ` [PATCH 09/13] perf gtk/browser: Trim column header string when event group enabled Namhyung Kim
2013-01-15 7:31 ` [PATCH 10/13] perf report: Bypass non-leader events when event group is enabled Namhyung Kim
2013-01-15 7:31 ` [PATCH 11/13] perf report: Show group description " Namhyung Kim
2013-01-15 7:31 ` [PATCH 12/13] perf report: Add --group option Namhyung Kim
2013-01-15 7:31 ` [PATCH 13/13] perf report: Add report.group config option Namhyung Kim
2013-01-15 18:38 ` [PATCHSET 00/13] perf report: Add support for event group view (v8) Arnaldo Carvalho de Melo
2013-01-16 10:33 ` Namhyung Kim
2013-01-16 18:29 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehhlmp4s.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox