From: Namhyung Kim <namhyung@kernel.org>
To: Feng Tang <feng.tang@intel.com>
Cc: acme@redhat.com, mingo@elte.hu, a.p.zijlstra@chello.nl,
andi@firstfloor.org, dsahern@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/7] perf ui/browser: Add browser for perf script
Date: Mon, 10 Sep 2012 10:35:32 +0900 [thread overview]
Message-ID: <87ehmabqxn.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1347007349-3102-1-git-send-email-feng.tang@intel.com> (Feng Tang's message of "Fri, 7 Sep 2012 16:42:22 +0800")
Hi Feng,
On Fri, 7 Sep 2012 16:42:22 +0800, Feng Tang wrote:
> Hi Arnaldo and all,
>
> This is a patch set mainly to add a browser for perf script, which
> will be integrated into the main hists and annotation browser.
>
> Patch 1-4 are some preparation for adding the script
> patch 5 introduce the script browser
> patch 6-7 integrate the browser to hists browser and annotation browser
>
> The patches are on top of current perf/core branch of your git tree.
> Please help to review.
>
> Namhyung,
>
> Many thanks for providing many good comments for the v1 patch sets. In
> this v2, I addressed most of those comments, for the suggestion to use
> browser for "perf script -l", I'll handle it later, and would post the
> v2 first for review.
>
> Changelog:
> Since v1:
> * Add filter for scripts can't be run in script browser
> * Fix some bugs about buffer handling and error check
For whole series,
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Thanks for your work!
Namhyung
prev parent reply other threads:[~2012-09-10 1:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 8:42 [PATCH v2 0/7] perf ui/browser: Add browser for perf script Feng Tang
2012-09-07 8:42 ` [PATCH v2 1/7] perf symbols: Filter samples with unresolved symbol when "--symbols" option is used Feng Tang
2012-09-19 15:21 ` [tip:perf/core] " tip-bot for Feng Tang
2012-09-07 8:42 ` [PATCH v2 2/7] perf scripts: Add --symbols option to handle specific symbols Feng Tang
2012-09-19 15:22 ` [tip:perf/core] " tip-bot for Feng Tang
2012-09-07 8:42 ` [PATCH v2 3/7] perf scripts: Add event_analyzing_sample-record/report Feng Tang
2012-09-19 15:23 ` [tip:perf/core] perf scripts: Add event_analyzing_sample-record/ report tip-bot for Feng Tang
2012-09-07 8:42 ` [PATCH v2 4/7] perf scripts: Export a find_scripts() function Feng Tang
2012-09-19 15:24 ` [tip:perf/core] " tip-bot for Feng Tang
2012-09-07 8:42 ` [PATCH v2 5/7] perf ui/browser: Add a browser for perf script Feng Tang
2012-09-07 8:42 ` [PATCH v2 6/7] perf ui/browser: Integrate script browser into annotation browser Feng Tang
2012-09-17 15:23 ` Arnaldo Carvalho de Melo
2012-09-18 7:40 ` Feng Tang
2012-09-18 11:30 ` Arnaldo Carvalho de Melo
2012-09-18 15:56 ` Feng Tang
2012-09-07 8:42 ` [PATCH v2 7/7] perf ui/browser: Integrate script browser into main hists browser Feng Tang
2012-09-10 1:35 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehmabqxn.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=feng.tang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox