From: Namhyung Kim <namhyung@kernel.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: David Ahern <dsahern@gmail.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 1/2] perf tools: Initial bash completion support
Date: Wed, 08 Aug 2012 14:26:17 +0900 [thread overview]
Message-ID: <87ehniymx2.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20120808052644.GA16930@somewhere.redhat.com> (Frederic Weisbecker's message of "Wed, 8 Aug 2012 07:26:48 +0200")
Hi, Frederic
On Wed, 8 Aug 2012 07:26:48 +0200, Frederic Weisbecker wrote:
> On Wed, Aug 08, 2012 at 10:10:02AM +0900, Namhyung Kim wrote:
>> On Tue, 07 Aug 2012 16:10:54 -0600, David Ahern wrote:
>> > On 8/7/12 11:00 AM, Frederic Weisbecker wrote:
>> >> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
>> >> index 35655c3..ddfb7e5 100644
>> >> --- a/tools/perf/Makefile
>> >> +++ b/tools/perf/Makefile
>> >> @@ -951,6 +951,7 @@ install: all
>> >> $(INSTALL) scripts/python/Perf-Trace-Util/lib/Perf/Trace/* -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python/Perf-Trace-Util/lib/Perf/Trace'
>> >> $(INSTALL) scripts/python/*.py -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python'
>> >> $(INSTALL) scripts/python/bin/* -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python/bin'
>> >> + $(INSTALL) -m 755 bash_completion $(DESTDIR_SQ)/etc/bash_completion.d/perf
>> >
>> > still getting an error here:
>> >
>> > $ make DESTDIR=/tmp/junk-perf O=/tmp/pbuild -C tools/perf/ install
>> > ...
>> > install -m 755 bash_completion /tmp/junk-perf/etc/bash_completion.d/perf
>> > install: cannot create regular file
>> > /tmp/junk-perf/etc/bash_completion.d/perf': No such file or directory
>> > make: *** [install] Error 1
>> > make: Leaving directory `/opt/sw/ahern/perf.git/tools/perf'
>>
>> Does patch below fix it?
>
> Thanks Namhyung.
>
> Can I have your signed-off-by to add this patch on my series?
>
Sure thing.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
>
>>
>>
>> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
>> index cfe4fc0b67f1..d0b27ba9663e 100644
>> --- a/tools/perf/Makefile
>> +++ b/tools/perf/Makefile
>> @@ -696,6 +696,7 @@ perfexecdir_SQ = $(subst ','\'',$(perfexecdir))
>> template_dir_SQ = $(subst ','\'',$(template_dir))
>> htmldir_SQ = $(subst ','\'',$(htmldir))
>> prefix_SQ = $(subst ','\'',$(prefix))
>> +sysconfdir_SQ = $(subst ','\'',$(sysconfdir))
>>
>> SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH))
>>
>> @@ -947,7 +948,8 @@ install: all
>> $(INSTALL) scripts/python/Perf-Trace-Util/lib/Perf/Trace/* -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python/Perf-Trace-Util/lib/Perf/Trace'
>> $(INSTALL) scripts/python/*.py -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python'
>> $(INSTALL) scripts/python/bin/* -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python/bin'
>> - $(INSTALL) -m 755 bash_completion $(DESTDIR_SQ)/etc/bash_completion.d/perf
>> + $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d'
>> + $(INSTALL) bash_completion '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d/perf'
>>
>> install-python_ext:
>> $(PYTHON_WORD) util/setup.py --quiet install --root='/$(DESTDIR_SQ)'
next prev parent reply other threads:[~2012-08-08 5:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 16:59 [PATCH 0/2] perf tools: Basic bash completion support v2 Frederic Weisbecker
2012-08-07 17:00 ` [PATCH 1/2] perf tools: Initial bash completion support Frederic Weisbecker
2012-08-07 22:10 ` David Ahern
2012-08-08 1:10 ` Namhyung Kim
2012-08-08 2:23 ` David Ahern
2012-08-08 5:26 ` Frederic Weisbecker
2012-08-08 5:26 ` Namhyung Kim [this message]
2012-08-07 17:00 ` [PATCH 2/2] perf tools: Support for events bash completion Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2012-08-07 13:19 [PATCH 0/2] perf tools: Basic bash completion support Frederic Weisbecker
2012-08-07 13:19 ` [PATCH 1/2] perf tools: Initial " Frederic Weisbecker
2012-08-07 14:11 ` David Ahern
2012-08-07 15:53 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehniymx2.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox