From: Rusty Russell <rusty@rustcorp.com.au>
To: Jim Cromie <jim.cromie@gmail.com>, Jason Baron <jbaron@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [00/11] pr_debug during module initialization
Date: Mon, 26 Mar 2012 10:54:30 +1030 [thread overview]
Message-ID: <87ehsgcipt.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAJfuBxztMMUrbUvVft8gXB4Jk2yi+AXVV-TVLXAFdtgMf4AUgg@mail.gmail.com>
On Fri, 23 Mar 2012 18:12:51 -0600, Jim Cromie <jim.cromie@gmail.com> wrote:
> > A previous version had a build-time error if a module used 'dyndbg' as a
> > module param - why did that get dropped?
>
> Rusty expressed view that if developers add it, they meant it.
> He also said the macro was redundant with another,
> but I didnt look further cuz of the 1st point.
Yeah, it was ugly overkill. I can't see someone accidently overriding
dyndbg, and let's assume that they know what they're doing (who knows,
they might want to enhance the parsing before calling the real dyndbg
parser).
Cheers,
Rusty.
--
How could I marry someone with more hair than me? http://baldalex.org
prev parent reply other threads:[~2012-03-26 4:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 23:01 [00/11] pr_debug during module initialization jim.cromie
2012-03-14 23:01 ` [PATCH 01/11] init: trivial tweaks to initcall_levels jim.cromie
2012-03-14 23:01 ` [PATCH 02/11] dynamic_debug: fix leading spaces jim.cromie
2012-03-14 23:01 ` [PATCH 03/11] dynamic_debug: replace if (verbose) pr_info with macro vpr_info jim.cromie
2012-03-14 23:01 ` [PATCH 04/11] dynamic_debug: change ddebug_query core param to dyndbg jim.cromie
2012-03-14 23:02 ` [PATCH 05/11] params: add param-name to parse_one's pr_debug() jim.cromie
2012-03-14 23:02 ` [PATCH 06/11] params: add 3rd arg to option handler callback signature jim.cromie
2012-03-14 23:02 ` [PATCH 07/11] dynamic_debug: make dynamic-debug work during module initialization jim.cromie
2012-03-14 23:02 ` [PATCH 08/11] pnp: if CONFIG_DYNAMIC_DEBUG, use pnp.dyndbg instead of pnp.debug jim.cromie
2012-03-14 23:02 ` [PATCH 09/11] dynamic_debug: add modname arg to exec_query callchain jim.cromie
2012-03-14 23:02 ` [PATCH 10/11] dynamic_debug: update Documentation/*, Kconfig.debug jim.cromie
2012-03-14 23:02 ` [PATCH 11/11] dynamic_debug: init with core_initcall, not arch_initcall jim.cromie
2012-03-19 2:04 ` [00/11] pr_debug during module initialization Rusty Russell
2012-03-19 6:17 ` Jim Cromie
2012-03-19 23:27 ` Rusty Russell
2012-03-23 20:27 ` Jason Baron
2012-03-24 0:12 ` Jim Cromie
2012-03-26 0:24 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehsgcipt.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=jbaron@redhat.com \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox