From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3] fat: don't use custom hex_to_bin()
Date: Thu, 29 Sep 2011 23:51:53 +0900 [thread overview]
Message-ID: <87ehyz8kqe.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <2c8e77b881028c0a11f3cfef4ebb231c3236d60c.1317302092.git.andriy.shevchenko@linux.intel.com> (Andy Shevchenko's message of "Thu, 29 Sep 2011 16:15:40 +0300")
Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> + /* The ip contains 2 bytes in little
> + * endian format. We need to get them
> + * in native endian. */
> +
> + rc = hex2bin(op++, ip + 3, 1);
> + if (rc < 0)
> + return -EINVAL;
> +
> + rc = hex2bin(op++, ip + 1, 1);
> + if (rc < 0)
> return -EINVAL;
> - }
> - *op++ = ec & 0xFF;
> - *op++ = ec >> 8;
> +
It will not work for big endian arch correctly like original code.
"ip" is made like following,
if (uni_xlate == 1) {
*op++ = ':';
op = pack_hex_byte(op, ec >> 8);
op = pack_hex_byte(op, ec);
len -= 5;
} else {
Maybe, my explanation was not good. Like above, "ip" format is like
":1234" (can say big endian, it's the string though), so, this code made
a unicode char (op) as little endian.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2011-09-29 14:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 11:32 [PATCH] alsa: 6fire: don't use custom hex_to_bin() Andy Shevchenko
2011-09-23 11:32 ` [PATCH] fat: " Andy Shevchenko
2011-09-23 12:05 ` Denys Vlasenko
2011-09-23 12:11 ` Andy Shevchenko
2011-09-27 11:48 ` [PATCHv2] " Andy Shevchenko
2011-09-27 17:19 ` OGAWA Hirofumi
2011-09-27 17:52 ` Andy Shevchenko
2011-09-27 18:06 ` Andy Shevchenko
2011-09-27 23:15 ` OGAWA Hirofumi
2011-09-29 13:07 ` Andy Shevchenko
2011-09-29 14:43 ` OGAWA Hirofumi
2011-09-29 14:54 ` Andy Shevchenko
2011-09-29 15:19 ` OGAWA Hirofumi
2011-09-29 15:10 ` [PATCHv4] " Andy Shevchenko
2011-09-29 15:37 ` Joe Perches
2011-09-29 18:27 ` OGAWA Hirofumi
2011-09-29 18:41 ` Joe Perches
2011-09-29 19:35 ` OGAWA Hirofumi
2011-09-29 13:15 ` [PATCHv3] " Andy Shevchenko
2011-09-29 14:51 ` OGAWA Hirofumi [this message]
2011-09-23 13:22 ` [PATCH] alsa: 6fire: " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehyz8kqe.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox