From: Kevin Hilman <khilman@ti.com>
To: "Munegowda\, Keshava" <keshava_mgowda@ti.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
linux-kernel@vger.kernel.org, ti@lists.linaro.org,
parthab@india.ti.com, sameo@linux.intel.com, gadiyar@ti.com,
balbi@ti.com, linux-omap@vger.kernel.org,
linux-usb@vger.kernel.org,
Jassi Brar <jaswinder.singh@linaro.org>
Subject: Re: [PATCH] mfd: omap: Restore TLL initialization
Date: Mon, 27 Jun 2011 15:04:09 -0700 [thread overview]
Message-ID: <87ei2f9bja.fsf@ti.com> (raw)
In-Reply-To: <BANLkTikFFUREhKyPaZrhHZje0KeaA3ef8Q@mail.gmail.com> (Keshava Munegowda's message of "Fri, 24 Jun 2011 11:52:25 +0530")
"Munegowda, Keshava" <keshava_mgowda@ti.com> writes:
> On Fri, Jun 24, 2011 at 2:31 AM, Jassi Brar <jassisinghbrar@gmail.com> wrote:
>> The commit
>> 7e6502d577106fb5b202bbaac64c5f1b065 'mfd: Add omap-usbhs runtime PM support'
>> besides moving to RPM, removes necessary TLL initialization as well.
>>
>> Restore the TLL initialization, without which device detection fails.
>>
>> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
[...]
> if you move to RPM, you should'tn access these configuration/reset
> registers in your driver.
Yes, but Jaswinder's changelog clearly shows that the runtime PM (and
thus hwmod) init is not doing the equivalent of what was removed from
the driver.
A hunch after a quick glance is that the driver changes are only doing
runtime PM calls on the UHH device and not the TTL device. In fact,
the patch that builds the USB host omap_device[1] doesn't even build one.
> moreover, the patch 'mfd: Add omap-usbhs runtime PM support' is
> already reverted.
It is reverted for this merge window, but will be added back for the
next window, so Jaswinder's problem still needs to be fixed the right way.
Please rework the USB host runtime PM conversion so that *all* the IP
blocks are managed by runtime PM and the driver is doing runtime PM
calls for all the devices used.
Kevin
[1] http://marc.info/?l=linux-omap&m=130693494126396&w=2
next prev parent reply other threads:[~2011-06-27 22:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 21:01 [PATCH] mfd: omap: Restore TLL initialization Jassi Brar
2011-06-24 6:22 ` Munegowda, Keshava
2011-06-24 7:03 ` Jaswinder Singh
2011-06-27 22:04 ` Kevin Hilman [this message]
2011-06-28 5:29 ` Munegowda, Keshava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ei2f9bja.fsf@ti.com \
--to=khilman@ti.com \
--cc=balbi@ti.com \
--cc=gadiyar@ti.com \
--cc=jassisinghbrar@gmail.com \
--cc=jaswinder.singh@linaro.org \
--cc=keshava_mgowda@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=parthab@india.ti.com \
--cc=sameo@linux.intel.com \
--cc=ti@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox