Re: [RFC 4/5] x86, Use NMI return notifier in MCE

Andi Kleen
2010-06-24T10:00:38Z

Huang Ying <ying.huang@intel.com> writes:

Hi Ying,

> {
> if (regs->flags & (X86_VM_MASK|X86_EFLAGS_IF)) {
> - mce_notify_irq();
> - /*
> - * Triggering the work queue here is just an insurance
> - * policy in case the syscall exit notify handler
> - * doesn't run soon enough or ends up running on the
> - * wrong CPU (can happen when audit sleeps)
> - */
> - mce_schedule_work();
> + __mce_report_event(NULL);

Do we still handle the CPU switch case correctly?

The backend handler needs to run on the same CPU to process the per
CPU mce pfns.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.