Re: [PATCH 1/2] [mmotm] Add notifiers for various swap events

Pekka Enberg
2009-12-28T18:43:27Z

Hi Andi,

Andi Kleen wrote:
>>> The first question to ask is if compressed swap is worth
>>> it. Do you have benchmark numbers showing it to be an improvement?
>>> Are there cases where it is slower than uncompressed swap?
>>>
>> http://code.google.com/p/compcache/wiki/Performance
>
> That should be included in the changelog of the patches.

Which patches? The driver is already in staging and there's a pointer to
the home page in

linux/drivers/staging/ramzswap/ramzswap.txt

>> ramzswap is an optional module.
>
> I have some doubts on the wisdom of making swap algorithms modular.
> Better compile them in. Then you don't need messy notifiers either.

What's so messy about them? The whole point of having the notifiers is
to avoid CONFIG_RAMZSWAP in core kernel code...

Pekka