public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: john stultz <johnstul@us.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@tglx.de>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: Duplicate vsyscall/vdso gettimeofday implementations on x86_64
Date: Sat, 18 Jul 2009 00:12:52 +0200	[thread overview]
Message-ID: <87eisfvtzv.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1247868130.8334.40.camel@localhost.localdomain> (john stultz's message of "Fri, 17 Jul 2009 15:02:10 -0700")

john stultz <johnstul@us.ibm.com> writes:

> I think the implementation in vclock_gettime.c is nice, as it mostly
> reuses the clock_gettime() code, but I don't think it actually gets
> called.

It depends on what glibc uses.

> Andi: You wrote the vclock_gettime.c, do you have any pointers about
> where you were going with this? Is there a reason you didn't clean it up
> when you implemented it originally?

The old style vsyscall cannot call the vDSO because it doesn't know
where it is mapped. And the new style vDSO cannot necessarily
call the old one vsyscall because there were plans 
to removing the old style vsyscall for some new programs to avoid
the last non randomized mapping (but that never got implemented). 

That is why there are two different ways to do this.

Neither can also call into the kernel of course.

In the current setup you could call into the static vsyscall, 
but that might need to be revised later.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

  reply	other threads:[~2009-07-17 22:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-17 22:02 Duplicate vsyscall/vdso gettimeofday implementations on x86_64 john stultz
2009-07-17 22:12 ` Andi Kleen [this message]
2009-07-17 22:54   ` john stultz
2009-07-18  6:07     ` Andi Kleen
2009-07-18  6:50       ` Andi Kleen
2009-07-18 22:03       ` john stultz
2009-07-19  7:22         ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eisfvtzv.fsf@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@tglx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox