From: Andi Kleen <andi@firstfloor.org>
To: Huang Ying <ying.huang@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andi Kleen <ak@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -v2] x86: MCE: Re-implement MCE log ring buffer as per-CPU ring buffer
Date: Tue, 28 Apr 2009 12:21:25 +0200 [thread overview]
Message-ID: <87eivdqdsq.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1240910841.6842.1163.camel@yhuang-dev.sh.intel.com> (Huang Ying's message of "Tue, 28 Apr 2009 17:27:21 +0800")
Huang Ying <ying.huang@intel.com> writes:
>
> ChangeLog:
>
> v2:
>
> - Use alloc_percpu() to allocate per_cpu mcelog buffer
Sorry, why didn't you just use DEFINE_PER_CPU ? That should work
as well and will be shorter.
Another thing I noticed. the "MACHINECHECK" signature was originally
for crash dump tools to find the log. If you change the format
you should change it to MACHINECHEC2 or so.
> + size_t usize_limit;
> +
> + /* Too large user buffer size may cause system not response */
> + usize_limit = num_possible_cpus() * MCE_LOG_LEN * sizeof(struct mce);
> + if (usize > usize_limit)
> + usize = usize_limit;
Did you ever track down what happens here? I still find it worrying
Otherwise looks good.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-04-28 10:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 9:27 [PATCH -v2] x86: MCE: Re-implement MCE log ring buffer as per-CPU ring buffer Huang Ying
2009-04-28 10:21 ` Andi Kleen [this message]
2009-04-29 1:31 ` Huang Ying
2009-04-29 6:11 ` Andi Kleen
2009-04-29 6:50 ` Huang Ying
2009-04-28 10:21 ` Peter Zijlstra
2009-04-28 10:33 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eivdqdsq.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox