From: Andi Kleen <andi@firstfloor.org>
To: "Vegard Nossum" <vegard.nossum@gmail.com>
Cc: "Pekka Enberg" <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"Rob Landley" <rob@landley.net>
Subject: Re: [RFC/PATCH] printk: detect incomplete lines
Date: Tue, 13 May 2008 12:54:23 +0200 [thread overview]
Message-ID: <87ej86scdc.fsf@basil.nowhere.org> (raw)
In-Reply-To: <19f34abd0805120500k7613dbd9le1bf79f7bb96778a@mail.gmail.com> (Vegard Nossum's message of "Mon, 12 May 2008 14:00:07 +0200")
"Vegard Nossum" <vegard.nossum@gmail.com> writes:
>
> Iirc, KERN_CONT is mostly an annotation for the checkpatch script to
> suppress the warning about missing loglevel token.
Perhaps it should be fixed to contain some magic token that is
then detected by printk and handled appropiately? And then perhaps
employee some kernel janitors to add it everywhere?
I think that would be preferable over any heuristics as implemented
in your original patch because there might be a legitimate need to
get out non full line printks ASAP for debugging.
-Andi
next prev parent reply other threads:[~2008-05-13 10:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 11:49 [RFC/PATCH] printk: detect incomplete lines Vegard Nossum
2008-05-12 11:56 ` Pekka Enberg
2008-05-12 12:00 ` Vegard Nossum
2008-05-13 10:54 ` Andi Kleen [this message]
2008-05-13 15:31 ` Vegard Nossum
2008-05-12 15:35 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ej86scdc.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=rob@landley.net \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox