From: Arne Redlich <arne.redlich@xiranet.com>
To: Roland Dreier <rolandd@cisco.com>
Cc: ofa-general <general@lists.openfabrics.org>,
lkml <linux-kernel@vger.kernel.org>,
erezz@voltaire.com
Subject: [PATCH 0/2] IB/iSER bugfixes
Date: Mon, 03 Mar 2008 11:35:48 +0100 [thread overview]
Message-ID: <87ejasxfgb.fsf@confield.dd.xiranet.com> (raw)
Hi,
While reading through the iSER code I noticed two rather nasty issues:
1. The iteration through the list of "iser_device"s during device
lookup/creation is broken - it might result in an infinite loop if more
than 1 HCA is used with iSER. Use list_for_each_entry() instead of the
custom, flawed list iteration code.
2. "iser_device" allocation failure is "handled" with a BUG_ON() right
before dereferencing the NULL-pointer.
This is really scary, so here's my idea of a fix. Someone with a deeper
understanding of the code should have a look at it since I'm not sure it
does The Right Thing.
Both patches are merely compile tested, and patch #2 needs to be applied
on top of #1.
Cheers,
Arne
reply other threads:[~2008-03-03 10:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ejasxfgb.fsf@confield.dd.xiranet.com \
--to=arne.redlich@xiranet.com \
--cc=erezz@voltaire.com \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox