From: Olaf Dietsche <olaf.dietsche#list.linux-kernel@t-online.de>
To: Oliver Neukum <oliver@neukum.name>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC] 2.5.42: remove capable(CAP_SYS_RAWIO) check from open_kmem
Date: Thu, 17 Oct 2002 19:00:54 +0200 [thread overview]
Message-ID: <87elap80ft.fsf@goat.bogus.local> (raw)
In-Reply-To: 200210171807.33178.oliver@neukum.name
Oliver Neukum <oliver@neukum.name> writes:
>> diff -urN a/drivers/char/mem.c b/drivers/char/mem.c
>> --- a/drivers/char/mem.c Sat Oct 5 18:44:55 2002
>> +++ b/drivers/char/mem.c Thu Oct 17 16:02:56 2002
>> @@ -525,7 +525,7 @@
>>
>> static int open_port(struct inode * inode, struct file * filp)
>> {
>> - return capable(CAP_SYS_RAWIO) ? 0 : -EPERM;
>> + return capable(CAP_SYS_KMEM) ? 0 : -EPERM;
>
> return capable(CAP_SYS_KMEM) && capable(CAP_SYS_RAWIO) ? 0 : _EPERM;
>
> Unless you check for RAWIO you can gain RAWIO by illegitimate means.
It's embarrassing, but it took until now for me to realize, that this
tries to protect CAP_SYS_RAWIO and not /dev/kmem. Well, thanks for
being patient with me.
> Now whether one place justifies a whole capability is another question.
This is unnecessary then.
Regards, Olaf.
next prev parent reply other threads:[~2002-10-17 16:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-13 12:46 [PATCH][RFC] 2.5.42: remove capable(CAP_SYS_RAWIO) check from open_kmem Olaf Dietsche
2002-10-17 11:00 ` Olaf Dietsche
2002-10-17 11:32 ` Chris Evans
2002-10-17 12:30 ` Chris Wright
2002-10-17 14:14 ` Olaf Dietsche
[not found] ` <200210171807.33178.oliver@neukum.name>
2002-10-17 17:00 ` Olaf Dietsche [this message]
[not found] <3DA985E6.6090302@colorfullife.com>
2002-10-13 15:48 ` Olaf Dietsche
[not found] ` <3DA99A8B.5050102@colorfullife.com>
2002-10-13 16:45 ` Olaf Dietsche
2002-10-13 17:04 ` Manfred Spraul
2002-10-13 22:05 ` Olaf Dietsche
2002-10-17 11:42 ` Andreas Steinmetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87elap80ft.fsf@goat.bogus.local \
--to=olaf.dietsche#list.linux-kernel@t-online.de \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.name \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox