From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AF1E41A78B for ; Mon, 6 Jul 2026 14:16:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783347393; cv=none; b=QZVviyYrtRZnF78cury9M/ZZaZI3lXqvaGjrJme2jjlg9Mhl48UWlJ3ARowVfvvZCxGylLAmQ/rQ75AsyIX2higujlEx8bIAnVx2910hdtROX7U5tGh8uFzzqilX+23rhfARCqmJd2hQVDFhn8IgfHHFpbWaPS6mq2OUHGdm9fw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783347393; c=relaxed/simple; bh=laMPtvyxoSoGCcf4cmCugbgh5uJZJxFkP3xn31Te1Zo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ZjmhwlkEAA8ZBC6t5P6Fq0NxbRJZaufW6jyeyLRlKcNxxuCAlLXS0B14pfGwvzafpgZamUTq6QIvpMxKOyULYoCF3Po9n7mE2G8ga/YMTAwGcn0htcvt7fkd1FSO/5YbWJUlpudcqq/TgMn2apaqkt/5i1be0Q8mSWEyz+ME9iQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=hsDQ7zyY; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="hsDQ7zyY" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id A4F55C8EC7B; Mon, 6 Jul 2026 14:16:42 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 897CB601A2; Mon, 6 Jul 2026 14:16:29 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7FFE911BB988C; Mon, 6 Jul 2026 16:16:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1783347389; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=mdP4MWzsmXpH1YpYiiTf9Hviww/mVOwpQ2Tgo3n5kSI=; b=hsDQ7zyYC0bCVGVwykLAHU281DFuoaPP9BP2lpohFMWWBdgM5j+g9BHvciB4+e+hWasK0x VzCs79YdK/6tPSU2JzB+LknVwIJ/w5Chuacc0YyX6kSgC18e/Ds45IKl0vcH172CHi4Z9s 6uBAvofJZVgMo58MtFBbuaKGt2DFYdZ3vuhnOpG+KncVfmit31ag3Xl/41SmtPzzThHl3R C4YsXPKPw34mfrn4W7WTrzzqewQTxEe8BZX+QQEnUJe6EKq6fWgF3vuX8IQ89+DFqEOMIJ J03dKk5/t8bM0APEGPsXLt8oXqrqIovTITaLkoU9Oy+NozTh3i9B3E5ZReFY1Q== From: Miquel Raynal To: "Michael Walle" Cc: "Pratyush Yadav" , "Takahiro Kuwano" , "Richard Weinberger" , "Vignesh Raghavendra" , "Tudor Ambarus" , , Subject: Re: [RFC PATCH 0/3] mtd: spi-nor: Rework flash parameter initialization In-Reply-To: <87zf04kz9s.fsf@bootlin.com> (Miquel Raynal's message of "Mon, 06 Jul 2026 15:45:19 +0200") References: <20260601125438.3481722-1-mwalle@kernel.org> <178331904816.868671.4599503585231715805.b4-ty@bootlin.com> <87zf04kz9s.fsf@bootlin.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Mon, 06 Jul 2026 16:16:25 +0200 Message-ID: <87fr1wkxty.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On 06/07/2026 at 15:45:19 +02, Miquel Raynal wr= ote: > Hello, > > On 06/07/2026 at 09:33:38 +02, "Michael Walle" wrote: > >> On Mon Jul 6, 2026 at 8:24 AM CEST, Miquel Raynal wrote: >>> On Mon, 01 Jun 2026 14:52:42 +0200, Michael Walle wrote: >>>> Try to simplify the flash initialization and get rid of the legacy >>>> handling. As default, all the flags of the in-kernel database are >>>> taken and amended with the SFDP data. >>>>=20 >>>> This might have the consequence that all the flashes now get a >>>> RDSFPD opcode which might be an unknown opcode. But that was already >>>> the case for any flashes which were unknown to the linux kernel. So >>>> far, there was not a single complaint. >>>>=20 >>>> [...] >>> >>> Applied to mtd/fixes, thanks! >>> >>> [1/3] mtd: spi-nor: spansion: s25fl256s0: remove SKIP_SFDP flag >>> (no commit info) >>> [2/3] mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failure >>> (no commit info) >>> [3/3] mtd: spi-nor: rework flash parameter initialization >>> (no commit info) >>> >>> Patche(s) should be available on mtd/linux.git and will be >>> part of the next PR (provided that no robot complains by then). >> >> Did you see, that there was a v1 of this series? There wasn't many >> changes for these three patches. Just what Tudor mentioned that the >> unsupported RDSFDP opcode should be mentioned in the commit message, >> too. >> >> Apart from that, the series now includes fixes that Sashiko found, >> that is, the rollback in case of a failed SFDP parsing is broken. I >> can also rebase that on top of these three patches. > > Sorry, I actually applied it last Friday and pushed only this morning. I > will drop the patches and apply v1. Actually, no. I did apply it to a local branch for testing, and I forgot about b4 picking it up. So these patches never reached linux-mtd (hence the "no commit" lines below each commit). There are two ways forward: - We consider the whole series for mtd/fixes (which I will likely send next week) and I take v1. - We keep the series for spi-nor/next and I let someone else apply it there. Thanks, Miqu=C3=A8l