From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0126039A4A7 for ; Thu, 2 Jul 2026 22:11:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783030272; cv=none; b=V3AEGNdN5ZhNSiZtzmpmCSSiTmyEBdZ0FZjxBjyLUCGiumoqEDPOSWPtq/Umwhm+Qhi+yqCEr1AFfonyYeAqT/7bX+gioCnz3CFAWrUm4dEf2kYHZVtLbhI6OcJRDHxbBEUnR/j0k7T+TniiMykBR47MXQ/dc9XMYwaxGlYD+K8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783030272; c=relaxed/simple; bh=YYD/HGC3JmCYMLLTXeGZDRQEdxQLJ3OJAKP4QYv564s=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=KuMB1MayA4zCHbF8B/wGakc/zd/sA9WeNf2bne60hhViLzOre5D9xoGQpks4yoNoCB2lvi0L0o5PAX6B4UgbLBShtAC7dOXGJ8H3JWOt7XRWy452HZt10uBaMWfK6Xvrr2HmXor52Eaz+B8/8wjb4OXz5tqoU1dBOB560X2m/pk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QsDtdhOS; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QsDtdhOS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 308DD1F000E9; Thu, 2 Jul 2026 22:11:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783030271; bh=KTAnE+u9MQ7zCsCjUohkPUkYeRSKtDuMTD3xJRmftpk=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=QsDtdhOShjFKwr2OFRsBTpheuuNxhbUr5FfTUemingkqV65aCS5lBwjDgdEeNMOz+ 7DwGbSfKnxRPVe7PB4vySO5ajFaFBEJs+Quv9GxcNucIjqulossH6DnZJpY8WPs32p KLeLL8+oHM8rSqz/Y57VOrnwL1ZSWno2bz+9o27qwLZM7dO13qQcT720KP46ZqYRT5 /l8urCyDgGgaz4m2QSv//dnzU2Nf2xRK31QRyFD6PG1mYLnDGXOHi//firMqnJM1uf lVraOCEz/zE3j1xokVp/KulpEX7O321x8vRW/aN7B+mH88R/9EpiwHqV1a9/Tzy6bY JMqdtF7LOyiaw== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wfPcj-00000000vf7-1QoC; Thu, 02 Jul 2026 22:11:09 +0000 Date: Thu, 02 Jul 2026 23:12:57 +0100 Message-ID: <87fr216nx2.wl-maz@kernel.org> From: Marc Zyngier To: Kemeng Shi Cc: tglx@kernel.org, jason@lakedaemon.net, lpieralisi@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/6] irqchip/gic-v3-its: Fix leak in its_vpe_irq_domain_alloc() In-Reply-To: <20260702033050.1583-4-shikemeng@huaweicloud.com> References: <20260702033050.1583-1-shikemeng@huaweicloud.com> <20260702033050.1583-4-shikemeng@huaweicloud.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: shikemeng@huaweicloud.com, tglx@kernel.org, jason@lakedaemon.net, lpieralisi@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 02 Jul 2026 04:30:47 +0100, Kemeng Shi wrote: > > When its_irq_gic_domain_alloc() fails, the following > its_vpe_irq_domain_free() skips calling its_vep_teardown() for the > corresponding irq. Call its_vpe_teardown() when its_irq_gic_domain_alloc() > is failedto avoid the leak issue. > > Fixes: 7d75bbb4bc1ad ("irqchip/gic-v3-its: Add VPE irq domain allocation/teardown") > Signed-off-by: Kemeng Shi > --- > drivers/irqchip/irq-gic-v3-its.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index 3e4edcb64065..8968bedefdba 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -4666,8 +4666,10 @@ static int its_vpe_irq_domain_alloc(struct irq_domain *domain, unsigned int virq > break; > err = its_irq_gic_domain_alloc(domain, virq + i, > vm->vpes[i]->vpe_db_lpi); > - if (err) > + if (err) { > + its_vpe_teardown(vm->vpes[i]); > break; > + } There is already a spot for error handling in this function, we don't need a second one. M. -- Jazz isn't dead. It just smells funny.