From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60750823DE for ; Thu, 14 May 2026 16:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.79.88.28 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778775208; cv=none; b=sL9D6KblKkXEkOWDZqL+jfLIUaDxYkYl28YnlNsabuO3X+HqOhT6mJTWNCXzw2iOeNN75mtdFXEURje2RyTni3Nq9Rh1M8b2vLEky+0XlvscpOuXT2ruNa3Zq7WsHFux+5KIlezgT6hcGsRUT15hPd2MH/fjg3t+Kcz0rjLBHHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778775208; c=relaxed/simple; bh=X5Ir/NRYdAPlhVABiuMcfFr3SJax4dwrXNMAdO6UTyg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Z0DbR2fbA6uv0eZ6YvzOaAiQ4ltok0vvosp86odKd4qdTLnxfkNfvnTualInMqAi/HVRyu9r0pFrqA1sEsbF5TSUCWpWty0ys8msNviccYarcggS1mc7oR0Dp3gZq2sQHH8ZSrtWNPd/63owgpTjQIDaJvR2XjqvNwweRMc8dLs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lwn.net; spf=pass smtp.mailfrom=lwn.net; dkim=pass (2048-bit key) header.d=lwn.net header.i=@lwn.net header.b=sH7NFE1e; arc=none smtp.client-ip=45.79.88.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lwn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lwn.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lwn.net header.i=@lwn.net header.b="sH7NFE1e" DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net 38E3D410BF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1778775201; bh=m/fsFTDc2wA3DaMFrGY8Euhe+kOGo1Il9+lyF59zjsI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=sH7NFE1eRfujrPAUHOGD8+7kc+bBtVpfdPdxqwvd8D5lkImqQNzhvK7I4wipnjMlW WL9a+kvlco1tV3nEhJFhBelW+GiEhRwepf8bE0XPnMyPpFQC7p/iGKbR8wBv/cR3IT LAOEg4+UjSFIqloVRrxP5HaixFYVHb0g4yg61l9JL1gTFnDCPwyKHaJ+DKlBw+iD9L tXjHGDaSMBsZZcANRqmW3r78XRhQVKjTXC8RNgZGDxFo3WGyhYW/8OR3r22nuyVrvQ 5hRrjTKM+NNyUcPNxlry5emGM0GfIG9IvBBtY1TTvZ0querJHHC7M0w9g2DKf/JqiB s7eNSue90480A== Received: from localhost (unknown [IPv6:2601:280:4600:27b:67c:16ff:fe81:5f9b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 38E3D410BF; Thu, 14 May 2026 16:13:21 +0000 (UTC) From: Jonathan Corbet To: Yash Rai , Mauro Carvalho Chehab Cc: linux-kernel@vger.kernel.org, Yash Rai Subject: Re: [PATCH] tools/lib/python: kdoc: remove unused parameters from _fill_text() and _format_usage() In-Reply-To: <20260514134952.62362-1-yash2154rai@gmail.com> References: <20260514134952.62362-1-yash2154rai@gmail.com> Date: Thu, 14 May 2026 10:13:20 -0600 Message-ID: <87fr3uufz3.fsf@trenco.lwn.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Yash Rai writes: > The parameter 'width' in _fill_text() and 'usage' and 'groups' > in _format_usage() are not used in enrich_formatter.py. > > This is a cleanup with no functional change. > > Signed-off-by: Yash Rai > --- > tools/lib/python/kdoc/enrich_formatter.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/lib/python/kdoc/enrich_formatter.py b/tools/lib/python/kdoc/enrich_formatter.py > index d1be4e5e1962..7e0f09f5ccea 100644 > --- a/tools/lib/python/kdoc/enrich_formatter.py > +++ b/tools/lib/python/kdoc/enrich_formatter.py > @@ -42,14 +42,14 @@ class EnrichFormatter(argparse.HelpFormatter): > lambda m: f'\033[1m{m.group(1)}\033[0m', text) > return text > > - def _fill_text(self, text, width, indent): > + def _fill_text(self, text, indent): > """ > Enrich descriptions with markups on it. > """ > enriched = self.enrich_text(text) > return "\n".join(indent + line for line in enriched.splitlines()) > > - def _format_usage(self, usage, actions, groups, prefix): > + def _format_usage(self, actions, prefix): > """ > Enrich positional arguments at usage: line. > """ Looking at this patch, my immediate response is that you didn't change any callers. That is ... because there are no callers. So, rather than tweak the argument lists, is there a reason to not just delete these functions altogether? Thanks, jon