From: Takashi Iwai <tiwai@suse.de>
To: Yuxuan Qiu <yuxuanqiu596@gmail.com>
Cc: perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: enable mute LED support on ThinkBook 16p
Date: Mon, 27 Apr 2026 14:14:17 +0200 [thread overview]
Message-ID: <87fr4gzjl2.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260424112107.22206-1-yuxuanqiu596@gmail.com>
On Fri, 24 Apr 2026 13:21:07 +0200,
Yuxuan Qiu wrote:
>
> On ThinkBook 16p systems the platform mute LED is present and
> bound to the audio-mute trigger, but it does not react to Master
> mute changes.
>
> The affected fixup chain sets up the DAC routing, but does not enable
> vmaster mute LED handling. Because of that, the generic HDA code does
> not mark Master Playback Switch with SNDRV_CTL_ELEM_ACCESS_SPK_LED,
> and the audio-mute trigger never receives speaker mute updates.
>
> Add a ThinkBook-specific wrapper around alc287_fixup_bind_dacs() and
> enable spec->gen.vmaster_mute_led during PRE_PROBE. This keeps the
> existing DAC binding logic unchanged while allowing the normal generic
> LED path to drive the mute LED.
>
> Signed-off-by: Yuxuan Qiu <yuxuanqiu596@gmail.com>
Thanks, applied now.
Takashi
prev parent reply other threads:[~2026-04-27 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 11:21 [PATCH] ALSA: hda/realtek: enable mute LED support on ThinkBook 16p Yuxuan Qiu
2026-04-27 12:14 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fr4gzjl2.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=yuxuanqiu596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox