From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: es1688: add ISA suspend and resume callbacks
Date: Wed, 01 Apr 2026 14:47:05 +0200 [thread overview]
Message-ID: <87fr5ergom.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260401-alsa-es1688-pm-v1-1-510767628fe6@gmail.com>
On Wed, 01 Apr 2026 13:45:37 +0200,
Cássio Gabriel wrote:
>
> The ISA ES1688 driver still carries a disabled suspend/resume block in
> its isa_driver definition, while the same file already provides minimal
> power-management handling for the PnP ES968 path.
>
> Add ISA-specific PM callbacks and factor the existing ES1688 suspend and
> resume sequence into common card-level helpers shared by both probe
> paths. Suspend moves the card to D3hot. Resume reinitializes the chip
> with snd_es1688_reset() and restores the card to D0, propagating reset
> failures to the caller.
>
> This wires up power-management callbacks for the ISA path and keeps the
> PM handling consistent between the ISA and PnP probe paths.
>
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Applied to for-next branch now. Thanks.
Takashi
prev parent reply other threads:[~2026-04-01 12:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 11:45 [PATCH] ALSA: es1688: add ISA suspend and resume callbacks Cássio Gabriel
2026-04-01 12:47 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fr5ergom.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox