From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 919D935B136; Thu, 12 Feb 2026 12:55:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770900934; cv=none; b=pgBSMGATmhGMbYRZxfzlh7oWLH+TCSu8Q3pO5uYZrWdRsGsGt+Pncyd495RFTj9WMiRvpTfmFccdELXoCvfEHX0lbfmp8h36CaFjCMgHbAbMBjvqGlkZY77A0QkwBKFAGd1Cd9Z736fPuNflrxCc+HirP8xDEJZoFzKfGmkZN/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770900934; c=relaxed/simple; bh=ZYUfg9IUcgRG8xYMOhkK38+v+A+PEda94EvJZMMhZFg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=WPHT92r3Gg6Nx/864A82lOOG+QHsjB7+bR5f87aMKjCNcXcaQ6l3fQLO1xZE+pGmRvjVPjWD5HA6p5XktIb6vA74VWQeq8m11+kDvbQcedTn6Lc09bjHrUFomdCgZIdvAEMXQlQPbdlt8jININHGScyFyrEPJjoHZvLwMDd0UKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=QbzF9AnV; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="QbzF9AnV" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id EA73CC23DA6; Thu, 12 Feb 2026 12:55:38 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id BA1F7606CA; Thu, 12 Feb 2026 12:55:29 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 6A630119708B8; Thu, 12 Feb 2026 13:55:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770900928; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=BMPMAwMYqQ+DI8Ds4Z6rKLFfzIVUJJ2dJif7/RBD8oM=; b=QbzF9AnVvDC59V1wOBN8pTDC7nakFCw23N+yQJD0Lqmjaw1ZBPUDK+zaT7F2viH4Wuwcoj nPGsE9TCLsMOjqB4iBzzzLkvWgxlqS8Zbwd/0X1iqmE+FcPCKMCJsuUEiuKwkdQ8DvlFB+ 1WbmMqWFSiILEqk6UTDf/VQQ8WaDeCUg2B37Wbe9yOyb6ywpI+caMOdSvAE/gV7hl64Yom R3ICAFwWKGVSBIL9fHqdDrbKJonFG3y4G8sQcN9XGV8Y9tKPsusVqvRtcP0vzEfiyAH3QR MeO2PwPzZjxQ+lbVIJKVWeSWqKQxdAAKbJ1Rl+EOOE/5Q5y+JdkXK9qfAywurg== From: Miquel Raynal To: "Michael Walle" Cc: "Santhosh Kumar K" , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v2 09/12] spi: cadence-quadspi: add PHY tuning infrastructure In-Reply-To: (Michael Walle's message of "Thu, 12 Feb 2026 12:14:05 +0100") References: <20260113141617.1905039-1-s-k6@ti.com> <20260113141617.1905039-10-s-k6@ti.com> <87qzqqxml7.fsf@bootlin.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Thu, 12 Feb 2026 13:55:22 +0100 Message-ID: <87fr76xgsl.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hello, >>>> + for_each_child_of_node(partition_np, part_np) { >>>> + if (of_property_read_string(part_np, "label", &label) || >>>> + !strstr(label, "phypattern")) >>>> + continue; >>> >>> There was already a review comment on the last version. Moving this >>> into the driver doesn't make it any better. In fact this might >>> create a (bad) precedent for future drivers. >> >> I remember complaining about it but not if there was a solution >> foreseen. In SPI NAND the solution has been found: the pattern is in the >> driver and we load it into cache before PHY tuning. But for SPI NOR I >> understood this wasn't possible. What would be an alternative? > > I'm not complaining about using a partition for the pattern but > about the hardcoded name of it. > > It was proposed to use at least a device tree phandle to point to a > partition (or so). Ah, yes indeed, thanks for clarifying this up (again) for me. I also agree the hardcoded name is not ideal. Thanks, Miqu=C3=A8l