From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C4D3347BC6 for ; Fri, 21 Nov 2025 13:44:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763732693; cv=none; b=Es5szkJ4i4lhotoXHlyFZotXHEx24IZbfq4BSWkAEHypiUJWkTUdJG0b/t7nVtF9al7ToKkso93/CSHANeQrqdM70q/cLxyswZP3eGV2N+SMY7ajGFJewX8+DmzZ4RUBSDxy+p3E34F33ozdSVIijV8sTdGexuKRhWRBLbcSJIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763732693; c=relaxed/simple; bh=E0PJANFh22hzlPBVzCkXtRS++lr7yTp27hrWIqEw9VE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=M/bGEpUqcn5ilySPUSOatsSPo0yTURfl68I7G7kfA8Koj3iMR3vuTg601xWaMpeBUVMEBt8Q075XAxfzqngwBdySXMnLPMD8NxLQJGYfOWokohd+jZpJjBGAHS1TFwa5PCnDNMHBuDboJ7glmUD5cAARX5PUZC4vChz+g6V1dmM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LH62XUe6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=L8/X9xhP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LH62XUe6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="L8/X9xhP" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AL9VwPv3048104 for ; Fri, 21 Nov 2025 13:44:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=E0PJANFh22hzlPBVzCkXtRS+ +lr7yTp27hrWIqEw9VE=; b=LH62XUe63WzP3NtgSEBKYQtA0C13hPRikHHU769S UL4E8mTnEi0Ain0oBSQqFPau+uUw1AttyciLUx+5bqBLJNjvSQ1szK9zhQBqzGmg Wvjbu/RPUhM9mFrKjKm8VEtdGGfN6wtjaWx2Bwb7l40ByXlXo6gQ2YpT6TXklMhk LRK5vOw9PFk87r8F4DYVDFSuAk4CXeru67TvVhavwZQt+OxhzNBg1f5gPnZDThjM jnQxQq2K063PfQeLk2t4gS+K9VjNo1eJ0vnaPwyCux3DPF1g+ASdNU1vWpbvbM+P iFKIkbUMNs6jDtT06dMiUbwbOMYdc0iHeI5K1+bGwnq7bg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ajnhjrq20-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Nov 2025 13:44:50 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8a5b03118f4so896771685a.1 for ; Fri, 21 Nov 2025 05:44:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763732689; x=1764337489; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=E0PJANFh22hzlPBVzCkXtRS++lr7yTp27hrWIqEw9VE=; b=L8/X9xhPUWIuEVfh8JGvRcIAGhj42Jn6TsDDxnfEb9z0PUrX9CTEYoGjARiwNB/aQX X9OUEP33F+n6wZyu74/Z2LmwzETTP8xAoApuVZxO4jjWwycgQgJM2vK7fcEcFzQX2UMO /7fWre5ZLI15xBiZjI2TYY+u5nkRsEFyk2cljZwgd+H8IjpzdxBRxsuoZ7mgUMPPvX2v Q8iVy/ELiQ0bc3NzEaf0gpUNFX8qr8v4MLV6kgfRpVKr1lEaLzpsJ9KmWUkBftr3I7XY DG7sY6N6Kv3L0CJHDk5xcw084h+XE/ituCw9WTTFKKde7dL5VHW8PNls9UQEZpUfCr5s rVnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763732689; x=1764337489; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=E0PJANFh22hzlPBVzCkXtRS++lr7yTp27hrWIqEw9VE=; b=e4U+l7XdUnQtb3dZgtTsQWnApbjg7JAsgghbI4z+4TU81FBq50gyYqOUTCZsbdBEti S9DFuscqi/85TKx6bBC4GQw479F1qwacqQAslbvudc4Vmt8f/bZtHcrDVLciFngXdL51 kn8nmHGvQbx93kp+6nLICu4duTVAaEvL5ghI3fGa2CzEMTZP2dZ/pWHWacLCc1SjGaFz ANmJ/PV118OMiHpeO9VvpthDP/2BZRgQybvrjk58yjm/xCUip/l1vx/9dg7PCDhBXV6+ FIO5blCoDuXCMBEP7tSIdrySA2eRE3SVI/Nz+Hw++wC9eoCgTfLOtwA7ufivVDCNz1gn 7kJg== X-Forwarded-Encrypted: i=1; AJvYcCVS51xRuRC987TF2JfauIxbbHhohOl3c9LEdI6ttMX9yDgxmc2+cypXe+ENtw1VVHRJHnSS5yXDeNdqk9s=@vger.kernel.org X-Gm-Message-State: AOJu0Yzg0OpCRaRySCCVTUrNwk+s45EBZ6f39sr1Nb6/rnTj6nWHP7Tl 84PZXOl7Vn+ufM8gx9bE9pH7cJLUNaJuqE4dRfM7lUNXk4pANW/Lu9Kf+ZhzT5KEvdizd8gmK6f ttE1pn6KjAzWWAQm9BmhSGegW4DQSTCZDC5VtM3Va/3OA9uuUAn8/SvUqe1TlcVOkH7E= X-Gm-Gg: ASbGncuVEGEG+KPsMwnh9FG41QjOv6mpRX9GJK86b5PkecrOU3E5GRJ12oCS+eXahmF lqk9tFG0HqySRHcHdS+zbbBgoklSmwMFDy5UWSSHe1TeVsPS0W/OWrGgp0xhuWZXrCPSXzGrezc yQUzXpdd0di68FECL+AEmki4zPxGNH4HtVDmvfU/faW73TIzdFwBhWfoW+gxnKn6qb/45aQh6SY jZox+OBJhaN4BDTX04oJb5ZLk+A37Vz7zfQhHBetUlWWm2I4Np5NGijl9KbEufZ8/2un8XCcWEu zRpuHgVOGOTJLwJUtAHn2H04nReCFJjnrKdXLQiNO49whb2vrLeUJxt48Uz0ZetL3Bv1dFydci2 ihas3gxhdeKJNy2kZFFeMldWM X-Received: by 2002:a05:620a:4149:b0:8b2:e9e1:4023 with SMTP id af79cd13be357-8b32ae1c485mr811100185a.27.1763732689551; Fri, 21 Nov 2025 05:44:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IFVJJt9LwWMFl+QHUjmwDukftW916ahnCuR1qHw/ai8/yFgovQIiqrAJDl9QbCTzeoGwhFhqQ== X-Received: by 2002:a05:620a:4149:b0:8b2:e9e1:4023 with SMTP id af79cd13be357-8b32ae1c485mr811096485a.27.1763732689062; Fri, 21 Nov 2025 05:44:49 -0800 (PST) Received: from localhost ([2a01:4b00:b703:c200:1ac0:4dff:fe39:5426]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-477a96aed1esm88851375e9.0.2025.11.21.05.44.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 05:44:48 -0800 (PST) From: Punit Agrawal To: Hanjun Guo Cc: Will Deacon , Punit Agrawal , , , , Subject: Re: [PATCH] arm64: acpi: Fix incorrect check for default console message In-Reply-To: <3d79dd24-b11b-7a21-d24b-3c6f85d54c0a@huawei.com> (Hanjun Guo's message of "Fri, 21 Nov 2025 10:40:30 +0800") References: <20251027141941.3089914-1-punit.agrawal@oss.qualcomm.com> <3d79dd24-b11b-7a21-d24b-3c6f85d54c0a@huawei.com> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Fri, 21 Nov 2025 13:44:47 +0000 Message-ID: <87fra7a4a8.fsf@stealth> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-ORIG-GUID: hD_K5xADt0lAzW41kxHAWaJerpKBjFRi X-Authority-Analysis: v=2.4 cv=SPlPlevH c=1 sm=1 tr=0 ts=69206cd2 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=i0EeH86SAAAA:8 a=_yJzmg8VWEz0JnKV7dEA:9 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIxMDA5OSBTYWx0ZWRfX31/hNh8PoekV ruUTcEG4i+/AZ2zGl4WMKR+yn8t8iYabV7AJzDUzCYgxR+BsrOIxWZlq5SNqEaD/LSL3CJagvi7 1IZy4zkUtb0R3unldg9u/SD96ZfBjpmK4hzVvuG+ygzzS23m+DJrZYTXb4kOQ81GbzEJsG2jZZ6 NigQBpCII6WR3U+Ok5Zgi8GsdYBLRM7NKahHLgMQAKrpuE3xqX6HH6qyUW0/LPL6+f4WNrxL/RJ Fnd+yyqFPyjyU/4fnU8d0ZDh358idOV/YlE8Ja9vbL3r1MMu/2FC//2Oec9+FgoNl3+WQrQUy1r 8/b4VCmvC1w+Ql98r+aQQDhPkoUn6mZsoPlSRSq/e0oeK7UFfvUF9KxDpIjIqULd4mi6tc8hxMQ x98aplzg8kmvLcJDRVmJqZtiYRVgpA== X-Proofpoint-GUID: hD_K5xADt0lAzW41kxHAWaJerpKBjFRi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-21_03,2025-11-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 spamscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511210099 Hi Hanjun, Hanjun Guo writes: > On 2025/10/30 22:21, Will Deacon wrote: >> On Mon, Oct 27, 2025 at 02:19:41PM +0000, Punit Agrawal wrote: >>> bad3fa2fb920 ("ACPI: Suppress misleading SPCR console message when >>> SPCR table is absent") mistakenly assumes acpi_parse_spcr() returning >>> 0 to indicate a failure to parse SPCR and prints a message to the >>> kernel logs accordingly. In reality acpi_parse_spcr() returns 0 on >>> success and -ERRNO on failure. >>> >>> Fix the faulty check to output the correct logging message. >>> >>> Fixes: bad3fa2fb920 ("ACPI: Suppress misleading SPCR console message when SPCR table is absent") >>> Signed-off-by: Punit Agrawal >>> --- >>> Hi, >>> >>> After sending a patch to fix incorrect parsing of SPCR[0], I was still >>> seeing inconsistent logging on arm64. The result is this nugget. >>> >>> Considering the pointless churn - I wondered if it isn't better to >>> drop the message? If others agree, I can send a patch (and revert >>> bad3fa2fb920 while at it). >> I'd be happy dropping the message as it looks pretty useless to me, >> especially given that the current logic is broken. > > Fine with me as well, in the acpi_parse_spcr() there is a default > pr_info() for the console information, we can drop it here. Thanks! I sent a follow up[0] that's been picked up as a fix for v6.18 (already merged). [0] https://lore.kernel.org/all/20251031111138.1262202-1-punit.agrawal@oss.qualcomm.com/