From: Takashi Iwai <tiwai@suse.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ALSA: core: fix up bus match const issues.
Date: Thu, 22 May 2025 15:16:51 +0200 [thread overview]
Message-ID: <87frgw9458.wl-tiwai@suse.de> (raw)
In-Reply-To: <2025052204-hyphen-thermal-3e72@gregkh>
On Thu, 22 May 2025 12:08:05 +0200,
Greg Kroah-Hartman wrote:
>
> In commit d69d80484598 ("driver core: have match() callback in struct
> bus_type take a const *"), the match bus callback was changed to have
> the driver be a const pointer. Unfortunately that const attribute was
> thrown away when container_of() is called, which is not correct and was
> not caught by the compiler due to how container_of() is implemented.
> Fix this up by correctly preserving the const attribute of the driver
> passed to the bus match function which requires the hdac_driver match
> function to also take a const pointer for the driver structure.
>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Fixes: d69d80484598 ("driver core: have match() callback in struct bus_type take a const *")
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2025-05-22 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 10:08 [PATCH] ALSA: core: fix up bus match const issues Greg Kroah-Hartman
2025-05-22 13:16 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frgw9458.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox