Re: [PATCH v2 2/3] rust: configfs: introduce rust support for configfs

[Andreas Hindborg <a.hindborg@kernel.org>]

"Danilo Krummrich" <dakr@kernel.org> writes:

> On Mon, Feb 17, 2025 at 12:08:22PM +0100, Andreas Hindborg wrote:
>> "Benno Lossin" <benno.lossin@proton.me> writes:
>>
>> > On 07.02.25 15:41, Andreas Hindborg wrote:

[...]

>> >> +    /// Implementations can use this method to do house keeping before
>> >> +    /// `configfs` drops its reference to `Child`.
>> >> +    fn drop_item(
>> >
>> > `drop` doesn't really fit here, I think something like `unlink_item`
>> > fits better, since the child isn't actually dropped after this function
>> > returns.
>>
>> Yea, I know. But the function is called `drop_item` on the C side of
>> things. Usually we keep the C names.
>
> I agree C names should be kept as possible.
>
> To me it seems obvious from the context, but maybe it'd still makes sense to add
> a brief note that this callback's name is not related to 'drop' in the sense of
> Rust?

Yes, good idea. I'll get than in for v4.


Best regards,
Andreas Hindborg