From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD9D53C1F; Sun, 12 Jan 2025 12:49:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736686155; cv=none; b=kor7msIfoQh4i98zO1vpe5M7Um/Dpd7ImgakpXehmmExjfIrCFeukJ+wBrllRhzD61lveh8L/KMplOXeiEiotVtX+MF8oMLevTmENWeD0hcu3nd0kxbH0n6NcS7K3EqKEh7PdPYMIocC/4WT9AkfSvKd8C99/SvgBCqMbi6hLeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736686155; c=relaxed/simple; bh=pgxRYdQSas+8D8GFL+/3jRqY0sesne7tj5/idkHo+64=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=PMSZEbBMwxdGKpAaXDohlk79MDiwbn36MZRX40WiwLYynbK/LzoYRis3FNbD3b67tB9hoZPT184kthaCqED98y7l8Mw4MPy00KZ2iKiytLDqGZW1CRkGdoOnzT5Sh8lNU2B9VC6F9Z4E3c1bFJ6arnybkzvgyu6Em3U6GYhUB0M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=D8LTWOkx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="D8LTWOkx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B727C4CEE2; Sun, 12 Jan 2025 12:49:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736686155; bh=pgxRYdQSas+8D8GFL+/3jRqY0sesne7tj5/idkHo+64=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=D8LTWOkxziU8CYSQSBNeQyDpwmMngkHtBPzbJPGF2zq3NgoKRMi2Hx6HM8NymWfDa mOeD4FqHiEs1IyC+hoNyXShzaa8LFHkqXs3EY/2ISsIEuLq1IXSIeYNW+8h2QFABA8 SPq749cIOB3uqvlzZy1Q2DV0mv2mj+UqwLEppMBRPbfp8r511nr2TM7/13kZp4hu47 NCTL9kZNRbjYu6opg1vUw2jIXY5lLy/3U4cPmxDqYwpD/vTjHIYhQmSoRMR9U5++7U CdFYJvcrL3qfqzj7XY7JVHhPcIX7apf2++UrlXIHij1gG9iuvOZEPzl68rpAnMn51g SfwIc+a1odiwg== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tWxOy-00BLMB-L3; Sun, 12 Jan 2025 12:49:12 +0000 Date: Sun, 12 Jan 2025 12:49:11 +0000 Message-ID: <87frloqjso.wl-maz@kernel.org> From: Marc Zyngier To: James Clark Cc: kvmarm@lists.linux.dev, oliver.upton@linux.dev, suzuki.poulose@arm.com, coresight@lists.linaro.org, James Clark , Mark Brown , Joey Gouly , Zenghui Yu , Catalin Marinas , Will Deacon , Mike Leach , Alexander Shishkin , Mark Rutland , Anshuman Khandual , "Rob Herring (Arm)" , Shiqi Liu , James Morse , Fuad Tabba , Raghavendra Rao Ananta , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 04/10] arm64/sysreg: Add a comment that the sysreg file should be sorted In-Reply-To: <20250107113252.260631-5-james.clark@linaro.org> References: <20250107113252.260631-1-james.clark@linaro.org> <20250107113252.260631-5-james.clark@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: james.clark@linaro.org, kvmarm@lists.linux.dev, oliver.upton@linux.dev, suzuki.poulose@arm.com, coresight@lists.linaro.org, james.clark@arm.com, broonie@kernel.org, joey.gouly@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, mike.leach@linaro.org, alexander.shishkin@linux.intel.com, mark.rutland@arm.com, anshuman.khandual@arm.com, robh@kernel.org, shiqiliu@hust.edu.cn, james.morse@arm.com, tabba@google.com, rananta@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 07 Jan 2025 11:32:41 +0000, James Clark wrote: > > From: James Clark > > There are a few entries particularly at the end of the file that aren't > in order. To avoid confusion, add a comment that might help new entries > to be added in the right place. > > Reviewed-by: Mark Brown > Signed-off-by: James Clark > Signed-off-by: James Clark > --- > arch/arm64/tools/sysreg | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > index b081b54d6d22..4ba167089e2a 100644 > --- a/arch/arm64/tools/sysreg > +++ b/arch/arm64/tools/sysreg > @@ -48,6 +48,8 @@ > # feature that introduces them (eg, FEAT_LS64_ACCDATA introduces enumeration > # item ACCDATA) though it may be more taseful to do something else. > > +# Please try to keep entries in this file sorted by sysreg encoding. > + > Sysreg OSDTRRX_EL1 2 0 0 0 2 > Res0 63:32 > Field 31:0 DTRRX "Do as I say, don't do as I do". I don't think this makes any sense if we don't actually sort the file the first place. M. -- Without deviation from the norm, progress is not possible.