From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A84F2010E2 for ; Wed, 8 Jan 2025 18:22:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736360542; cv=none; b=Ep7chm+zXExr+AAs2DsD/gOVF6YV7vq/mAPrKgPcn7Ar0Tim8WEO39sIeU8xxDF6deQj8HoXPCsjgG7eyQ56DHrrVJplm6K2QE6j3veV5V61knnOm+9RPz99DESxtc4wdbDL9G9HQZdTRu1rI8V7KBtXAuz+a0ubMxhC91V1m5I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736360542; c=relaxed/simple; bh=OJh8zj/mYNrDdbCSbSfAplhA224phCF3UCHCrpKJiLM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Ll3z0PA8DQJvBYMoqNEhbVkd+7SadhyOtovVdPm2TS4Hh//an6yaKDd7ug7UnbrSi8xGTFalPk8Yktw5Ot4DIMHR6Yvk6hHv9DUfzMdT8/FBpFopH6z+MlPjZX/jfz55/kbInoS8DkOAn8QZ0v7m1uVrBL4qwMIIA4D+toTIniM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=lxueUb95; arc=none smtp.client-ip=217.70.183.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="lxueUb95" Received: by mail.gandi.net (Postfix) with ESMTPSA id 10D61FF803; Wed, 8 Jan 2025 18:22:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1736360538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=le5QEQ/DFOh99eUQD33pyz6znp5cwLwQiHbsdo17X5I=; b=lxueUb95vRHVLa8UhdsU167Ql++vzNsQgUX6VMWpZlP+WjCQYI4o+XnsQ6585x8Y7mDNFK Ci5n7pxELsL/b/QkNjz2A8Q//mXYH9kXOsvxYdKJBGWIvJQsxxNRpMLioHWgOwGk8YDAQL 5i90ci0oMw+Oo0wp4+4qBmYCtysZ0/8jct9+NN4Gc6yjf+M5DXSHowNJgGPWLVvTjr1t+9 QwyAlzBkookPn9Ia2FXpqptTxAmzEebx8zFB0H9sdJiKJPP0zGzI84jkYhHof7vRggrLra WMcl0CiE2CrlDx197UTFLJQRi4JYBTru1ABJsqNAkTT0z8WpdeE+R3JGWtoVjw== From: Miquel Raynal To: Pratyush Yadav Cc: Tudor Ambarus , Michael Walle , Richard Weinberger , Vignesh Raghavendra , Thomas Petazzoni , Steam Lin , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mtd: spi-nor: winbond: Add support for w25q01jv In-Reply-To: (Pratyush Yadav's message of "Tue, 24 Dec 2024 21:15:41 +0000") References: <20241224-winbond-6-12-rc1-nor-volatile-bit-v1-0-f7c4dff66182@bootlin.com> <20241224-winbond-6-12-rc1-nor-volatile-bit-v1-1-f7c4dff66182@bootlin.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Wed, 08 Jan 2025 19:22:16 +0100 Message-ID: <87frltf9nr.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hello Pratyush, >> static const struct spi_nor_otp_ops winbond_nor_otp_ops =3D { >> .read =3D spi_nor_otp_read_secr, >> .write =3D spi_nor_otp_write_secr, >> @@ -334,6 +413,9 @@ static int winbond_nor_late_init(struct spi_nor *nor) >> { >> struct spi_nor_flash_parameter *params =3D nor->params; >>=20=20 >> + if (params->n_dice > 1) >> + params->ready =3D winbond_multi_die_ready; >> + > > Is this true for all multi-die Winbond flashes, and going to hold true > for future ones? If not, I suppose this should go in the flash-specific > fixup hook. Do it in either the flash-specific late_init hook, or in the > post_sfdp hook, I have no strong opinions. So, after talking to Winbond, it appears that we can reduce the scope of this fixup to the following parts which are impacted: - W25Q0{1,2}JV - W25H0{1,2}JV - W25Q0{1,2}NW - W35T0{1,2}NW Future chips being fixed in hardware. I'll probably use the post_sfdp flash-specific hook as you suggest. Thanks, Miqu=C3=A8l