public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: usb-audio: Fix Yamaha P-125 Quirk Entry
@ 2024-11-11 16:45 Eryk Zagorski
  2024-11-12 14:38 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Eryk Zagorski @ 2024-11-11 16:45 UTC (permalink / raw)
  To: linux-sound, linux-kernel; +Cc: tiwai, soyjuanarbol, erykzagorski

This patch switches the P-125 quirk entry to use a composite quirk as the
P-125 supplies both MIDI and Audio like many of the other Yamaha
keyboards

Signed-off-by: Eryk Zagorski <erykzagorski@gmail.com>
---
 sound/usb/quirks-table.h | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
index 24c981c9b240..199d0603cf8e 100644
--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -324,7 +324,6 @@ YAMAHA_DEVICE(0x105a, NULL),
 YAMAHA_DEVICE(0x105b, NULL),
 YAMAHA_DEVICE(0x105c, NULL),
 YAMAHA_DEVICE(0x105d, NULL),
-YAMAHA_DEVICE(0x1718, "P-125"),
 {
 	USB_DEVICE(0x0499, 0x1503),
 	QUIRK_DRIVER_INFO {
@@ -391,6 +390,19 @@ YAMAHA_DEVICE(0x1718, "P-125"),
 		}
 	}
 },
+{
+	USB_DEVICE(0x0499, 0x1718),
+	QUIRK_DRIVER_INFO {
+		/* .vendor_name = "Yamaha", */
+		/* .product_name = "P-125", */
+		QUIRK_DATA_COMPOSITE {
+			{ QUIRK_DATA_STANDARD_AUDIO(1) },
+			{ QUIRK_DATA_STANDARD_AUDIO(2) },
+			{ QUIRK_DATA_MIDI_YAMAHA(3) },
+			QUIRK_COMPOSITE_END
+		}
+	}
+},
 YAMAHA_DEVICE(0x2000, "DGP-7"),
 YAMAHA_DEVICE(0x2001, "DGP-5"),
 YAMAHA_DEVICE(0x2002, NULL),
-- 
2.47.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: usb-audio: Fix Yamaha P-125 Quirk Entry
  2024-11-11 16:45 [PATCH] ALSA: usb-audio: Fix Yamaha P-125 Quirk Entry Eryk Zagorski
@ 2024-11-12 14:38 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2024-11-12 14:38 UTC (permalink / raw)
  To: Eryk Zagorski; +Cc: linux-sound, linux-kernel, tiwai, soyjuanarbol

On Mon, 11 Nov 2024 17:45:21 +0100,
Eryk Zagorski wrote:
> 
> This patch switches the P-125 quirk entry to use a composite quirk as the
> P-125 supplies both MIDI and Audio like many of the other Yamaha
> keyboards
> 
> Signed-off-by: Eryk Zagorski <erykzagorski@gmail.com>

Thanks, applied now.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-12 14:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-11 16:45 [PATCH] ALSA: usb-audio: Fix Yamaha P-125 Quirk Entry Eryk Zagorski
2024-11-12 14:38 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox