From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6ED313E88C for ; Fri, 4 Oct 2024 09:10:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728033021; cv=none; b=AqmryHgTqcRDDbtBm0ZEp0nUxGGRPYdg0rdeDYcpMiDk0PRtGD02E5nhHQ/qJoK0GtbWV+2wZ4BVeLvk8N2e2AKYVtHMOsj1HPk+m54Hf5v1VayWI+eOrCTYfOaE+sL+TJ8MLytWAPpsxBUNovpCm2CBpB0dFJd69CCMXQW5cwU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728033021; c=relaxed/simple; bh=QTYuQh0P26vRKNsQewIzdoWVB1PnsOxVnuBkST55Nmk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=SjJ5g5snaACVVcte/9ZATJdXpIIiRzZjkxEdweQGNCvREMgaNoR3gLSNhJf57knFKhMgT2LXUJDHrOLnme+gxpn2+UldOu7kEPL7Wf+6JD8ozewqO3fpM4xNRf50KUcAu+kNKcbEa2f1kR8kAdzsdsN1IDyNyxo7LcPr7VAESfc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WtfI6LvU; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WtfI6LvU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728033018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XWaxtFyxCVqdKiE9UC3u3v1VjOYPBu3LjrsGcjWBoPY=; b=WtfI6LvUluHMSoUrs42wJvkyJO2T7Z7xynQshFnksxqDi7L97GOu8BhOpspDuLNKtULw6m bxzEXeQ0RhCeASgoLdg/9PwIWM2O3z7DFbSexD2iBXC7z/HpPOdned5siwcvsaZEFK0YnT 0lv+dyzo4q3PmP1RDGacamp5Phajq2k= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-vz-n68IhOSqwIAWewBHBjw-1; Fri, 04 Oct 2024 05:10:17 -0400 X-MC-Unique: vz-n68IhOSqwIAWewBHBjw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42cdeac2da6so14155105e9.2 for ; Fri, 04 Oct 2024 02:10:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728033016; x=1728637816; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XWaxtFyxCVqdKiE9UC3u3v1VjOYPBu3LjrsGcjWBoPY=; b=AwMKyWGKgMjpS5fXOIfFSnJbEsqBNqsgSQLGn04bSgvdyTIOb+tfSGh6mxriar2MKW Td5H93rcAizlGTuWCXUe3yAXCRaP5PSu1I+8nMk9plC+fKd1DMcJclrfrQmHSzt0nCFE H/3BdLEEZqESeLvA0oFV70jyJH6hl/reGjc1z/hVDyEng82es7YLFqAdpoUsfGE9gGP9 +Gd44JpMiDzprS3iLwqlvrKyy6FE9Y4Q/BYyJMtAESUJVIYT0W8bG0flkQJm5IroxSVH KJEe18CbyyJRPVz3rqh1JqirEPIbz0opIT4S4AldIaByH8EskKRLku2BwClfd/vSeUxE V5oQ== X-Forwarded-Encrypted: i=1; AJvYcCXdNbZOH09YtMUhm/ZGubvFZIhAC08QjxQ3WtTO1p2zrrsZFdFZ2shwDYVK+zIiSZMPLrZBXcxRlIUBlFs=@vger.kernel.org X-Gm-Message-State: AOJu0YxjR254I8LEwN7FGtOfJx6OFXXZBAJG/twfh7yIiPd15mNfyEmN m4hFk71O8cmT0DHSl4TcGwM5v1spL5NysrtkKbqTaQXHkZbbe5Jz0/+qPE3q6+1TRHaq6KkBSLL BSkFP/nzIVGn4ntK9OAGcN2OA9Ptm8kSh9w9dBv8CDpXXWik4b/ZtpdGvTFJOXQxY7y2NbL6wt3 a/mH1FElZjj9nTwCR2vDQHG/JJWqsZeJK1UQ1v5m6+ygiyGw== X-Received: by 2002:a05:600c:35c3:b0:428:f0c2:ef4a with SMTP id 5b1f17b1804b1-42f85aa817emr14424245e9.13.1728033016354; Fri, 04 Oct 2024 02:10:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHTm157t6QcMf8gjoAtCEnaqJykgnp6tIfLsplWcv2x4DJAc1A+hAkLVGTelF1r+AOWTAiLCA== X-Received: by 2002:a05:600c:35c3:b0:428:f0c2:ef4a with SMTP id 5b1f17b1804b1-42f85aa817emr14423975e9.13.1728033015874; Fri, 04 Oct 2024 02:10:15 -0700 (PDT) Received: from fedora (g2.ign.cz. [91.219.240.8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f86b1d640sm10512925e9.25.2024.10.04.02.10.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 02:10:15 -0700 (PDT) From: Vitaly Kuznetsov To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/11] KVM: selftests: Drop manual XCR0 configuration from state test In-Reply-To: <20241003234337.273364-10-seanjc@google.com> References: <20241003234337.273364-1-seanjc@google.com> <20241003234337.273364-10-seanjc@google.com> Date: Fri, 04 Oct 2024 11:10:14 +0200 Message-ID: <87frpci689.fsf@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Sean Christopherson writes: > Now that CR4.OSXSAVE and XCR0 are setup by default, drop the manual > enabling from the state test, which is fully redundant with the default > behavior. > > Signed-off-by: Sean Christopherson > --- > tools/testing/selftests/kvm/x86_64/state_test.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/tools/testing/selftests/kvm/x86_64/state_test.c b/tools/testing/selftests/kvm/x86_64/state_test.c > index 1c756db329e5..141b7fc0c965 100644 > --- a/tools/testing/selftests/kvm/x86_64/state_test.c > +++ b/tools/testing/selftests/kvm/x86_64/state_test.c > @@ -145,11 +145,6 @@ static void __attribute__((__flatten__)) guest_code(void *arg) > > memset(buffer, 0xcc, sizeof(buffer)); > > - set_cr4(get_cr4() | X86_CR4_OSXSAVE); > - GUEST_ASSERT(this_cpu_has(X86_FEATURE_OSXSAVE)); > - > - xsetbv(0, xgetbv(0) | supported_xcr0); > - > /* > * Modify state for all supported xfeatures to take them out of > * their "init" state, i.e. to make them show up in XSTATE_BV. Reviewed-by: Vitaly Kuznetsov -- Vitaly