public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Brian Norris <briannorris@chromium.org>,
	 Francesco Dolcini <francesco@dolcini.it>,
	 David Lin <yu-hao.lin@nxp.com>,
	linux-wireless@vger.kernel.org,  linux-kernel@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH] wifi: mwifiex: keep mwifiex_cfg80211_ops constant
Date: Fri, 09 Aug 2024 13:26:31 +0300	[thread overview]
Message-ID: <87frre2drc.fsf@kernel.org> (raw)
In-Reply-To: <20240809-mwifiex-duplicate-mwifiex_cfg80211_ops-v1-1-23e0e6290ace@pengutronix.de> (Sascha Hauer's message of "Fri, 09 Aug 2024 11:51:48 +0200")

Sascha Hauer <s.hauer@pengutronix.de> writes:

> With host_mlme support being added mwifiex_cfg80211_ops is no longer
> constant, but supplemented with the host_mlme related ops when host_mlme
> support is enabled. This doesn't work with multiple adapters when only
> few of then have host_mlme support. Duplicate mwifiex_cfg80211_ops
> before using it and keep the original constant.
>
> While at it mark mwifiex_cfg80211_ops const to prevent people from
> changing it again during runtime.
>
> Fixes: 36995892c271c ("wifi: mwifiex: add host mlme for client mode")
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> Kalle, the commit breaking it still sits in wireless-next. Feel free to
> squash this into the original commit if convenient for you.

Thanks for the note, info like this helps a lot. We avoid rebasing
wireless trees unless there's something really critical, so squashing is
not really an option.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2024-08-09 10:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09  9:51 [PATCH] wifi: mwifiex: keep mwifiex_cfg80211_ops constant Sascha Hauer
2024-08-09 10:26 ` Kalle Valo [this message]
2024-08-09 12:37 ` Francesco Dolcini
2024-08-13 16:48 ` Brian Norris
2024-08-16 10:07 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frre2drc.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=briannorris@chromium.org \
    --cc=francesco@dolcini.it \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=yu-hao.lin@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox