* [PATCH v1 1/4] ALSA: hda: cs35l41: Support Lenovo Thinkbook 16P Gen 5
2024-06-06 13:03 [PATCH v1 0/4] Add support for Lenovo Thinkbooks Stefan Binding
@ 2024-06-06 13:03 ` Stefan Binding
2024-06-06 13:03 ` [PATCH v1 2/4] ALSA: hda: cs35l41: Support Lenovo Thinkbook 13x Gen 4 Stefan Binding
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Stefan Binding @ 2024-06-06 13:03 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, linux-sound, linux-kernel, patches, Stefan Binding
This laptop does not contain _DSD so needs to be supported using the
configuration table.
Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
---
sound/pci/hda/cs35l41_hda_property.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
index 6a7a6d486916..046a94250683 100644
--- a/sound/pci/hda/cs35l41_hda_property.c
+++ b/sound/pci/hda/cs35l41_hda_property.c
@@ -128,6 +128,8 @@ static const struct cs35l41_config cs35l41_config_table[] = {
{ "17AA38B5", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
{ "17AA38B6", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
{ "17AA38B7", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
+ { "17AA38F9", 2, EXTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
+ { "17AA38FA", 2, EXTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
{}
};
@@ -529,6 +531,8 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
{ "CSC3551", "17AA38B5", generic_dsd_config },
{ "CSC3551", "17AA38B6", generic_dsd_config },
{ "CSC3551", "17AA38B7", generic_dsd_config },
+ { "CSC3551", "17AA38F9", generic_dsd_config },
+ { "CSC3551", "17AA38FA", generic_dsd_config },
{}
};
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v1 2/4] ALSA: hda: cs35l41: Support Lenovo Thinkbook 13x Gen 4
2024-06-06 13:03 [PATCH v1 0/4] Add support for Lenovo Thinkbooks Stefan Binding
2024-06-06 13:03 ` [PATCH v1 1/4] ALSA: hda: cs35l41: Support Lenovo Thinkbook 16P Gen 5 Stefan Binding
@ 2024-06-06 13:03 ` Stefan Binding
2024-06-06 13:03 ` [PATCH v1 3/4] ALSA: hda/realtek: Support Lenovo Thinkbook 16P Gen 5 Stefan Binding
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Stefan Binding @ 2024-06-06 13:03 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, linux-sound, linux-kernel, patches, Stefan Binding
This laptop does not contain _DSD so needs to be supported using the
configuration table.
Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
---
sound/pci/hda/cs35l41_hda_property.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
index 046a94250683..51998d1c72ff 100644
--- a/sound/pci/hda/cs35l41_hda_property.c
+++ b/sound/pci/hda/cs35l41_hda_property.c
@@ -128,6 +128,8 @@ static const struct cs35l41_config cs35l41_config_table[] = {
{ "17AA38B5", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
{ "17AA38B6", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
{ "17AA38B7", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
+ { "17AA38C7", 4, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT }, 0, 2, -1, 1000, 4500, 24 },
+ { "17AA38C8", 4, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT }, 0, 2, -1, 1000, 4500, 24 },
{ "17AA38F9", 2, EXTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
{ "17AA38FA", 2, EXTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
{}
@@ -531,6 +533,8 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
{ "CSC3551", "17AA38B5", generic_dsd_config },
{ "CSC3551", "17AA38B6", generic_dsd_config },
{ "CSC3551", "17AA38B7", generic_dsd_config },
+ { "CSC3551", "17AA38C7", generic_dsd_config },
+ { "CSC3551", "17AA38C8", generic_dsd_config },
{ "CSC3551", "17AA38F9", generic_dsd_config },
{ "CSC3551", "17AA38FA", generic_dsd_config },
{}
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v1 3/4] ALSA: hda/realtek: Support Lenovo Thinkbook 16P Gen 5
2024-06-06 13:03 [PATCH v1 0/4] Add support for Lenovo Thinkbooks Stefan Binding
2024-06-06 13:03 ` [PATCH v1 1/4] ALSA: hda: cs35l41: Support Lenovo Thinkbook 16P Gen 5 Stefan Binding
2024-06-06 13:03 ` [PATCH v1 2/4] ALSA: hda: cs35l41: Support Lenovo Thinkbook 13x Gen 4 Stefan Binding
@ 2024-06-06 13:03 ` Stefan Binding
2024-06-06 13:03 ` [PATCH v1 4/4] ALSA: hda/realtek: Support Lenovo Thinkbook 13x Gen 4 Stefan Binding
2024-06-13 12:11 ` [PATCH v1 0/4] Add support for Lenovo Thinkbooks Takashi Iwai
4 siblings, 0 replies; 6+ messages in thread
From: Stefan Binding @ 2024-06-06 13:03 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, linux-sound, linux-kernel, patches, Stefan Binding
Add support for this laptop, which uses CS35L41 HDA amps.
The laptop does not contain valid _DSD for these amps, so requires
entries into the CS35L41 configuration table to function correctly.
Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
---
sound/pci/hda/patch_realtek.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index aa76d1c88589..6cb258978666 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10544,6 +10544,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x38cd, "Y790 VECO DUAL", ALC287_FIXUP_TAS2781_I2C),
SND_PCI_QUIRK(0x17aa, 0x38d2, "Lenovo Yoga 9 14IMH9", ALC287_FIXUP_YOGA9_14IMH9_BASS_SPK_PIN),
SND_PCI_QUIRK(0x17aa, 0x38d7, "Lenovo Yoga 9 14IMH9", ALC287_FIXUP_YOGA9_14IMH9_BASS_SPK_PIN),
+ SND_PCI_QUIRK(0x17aa, 0x38F9, "Thinkbook 16P Gen5", ALC287_FIXUP_CS35L41_I2C_2),
+ SND_PCI_QUIRK(0x17aa, 0x38FA, "Thinkbook 16P Gen5", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v1 4/4] ALSA: hda/realtek: Support Lenovo Thinkbook 13x Gen 4
2024-06-06 13:03 [PATCH v1 0/4] Add support for Lenovo Thinkbooks Stefan Binding
` (2 preceding siblings ...)
2024-06-06 13:03 ` [PATCH v1 3/4] ALSA: hda/realtek: Support Lenovo Thinkbook 16P Gen 5 Stefan Binding
@ 2024-06-06 13:03 ` Stefan Binding
2024-06-13 12:11 ` [PATCH v1 0/4] Add support for Lenovo Thinkbooks Takashi Iwai
4 siblings, 0 replies; 6+ messages in thread
From: Stefan Binding @ 2024-06-06 13:03 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, linux-sound, linux-kernel, patches, Stefan Binding
Add support for this laptop, which uses CS35L41 HDA amps.
The laptop does not contain valid _DSD for these amps, so requires
entries into the CS35L41 configuration table to function correctly.
Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
---
sound/pci/hda/patch_realtek.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 6cb258978666..621b525a3c14 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10540,6 +10540,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x38be, "Yoga S980-14.5 proX YC Dual", ALC287_FIXUP_TAS2781_I2C),
SND_PCI_QUIRK(0x17aa, 0x38bf, "Yoga S980-14.5 proX LX Dual", ALC287_FIXUP_TAS2781_I2C),
SND_PCI_QUIRK(0x17aa, 0x38c3, "Y980 DUAL", ALC287_FIXUP_TAS2781_I2C),
+ SND_PCI_QUIRK(0x17aa, 0x38c7, "Thinkbook 13x Gen 4", ALC287_FIXUP_CS35L41_I2C_4),
+ SND_PCI_QUIRK(0x17aa, 0x38c8, "Thinkbook 13x Gen 4", ALC287_FIXUP_CS35L41_I2C_4),
SND_PCI_QUIRK(0x17aa, 0x38cb, "Y790 YG DUAL", ALC287_FIXUP_TAS2781_I2C),
SND_PCI_QUIRK(0x17aa, 0x38cd, "Y790 VECO DUAL", ALC287_FIXUP_TAS2781_I2C),
SND_PCI_QUIRK(0x17aa, 0x38d2, "Lenovo Yoga 9 14IMH9", ALC287_FIXUP_YOGA9_14IMH9_BASS_SPK_PIN),
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1 0/4] Add support for Lenovo Thinkbooks
2024-06-06 13:03 [PATCH v1 0/4] Add support for Lenovo Thinkbooks Stefan Binding
` (3 preceding siblings ...)
2024-06-06 13:03 ` [PATCH v1 4/4] ALSA: hda/realtek: Support Lenovo Thinkbook 13x Gen 4 Stefan Binding
@ 2024-06-13 12:11 ` Takashi Iwai
4 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2024-06-13 12:11 UTC (permalink / raw)
To: Stefan Binding
Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-sound,
linux-kernel, patches
On Thu, 06 Jun 2024 15:03:47 +0200,
Stefan Binding wrote:
>
> These laptops do not contain _DSD required to support CS35L41 HDA.
> To workaround this, add support for these laptops into the configuration
> table in cs35l41_hda_property.c.
> Also add the required entries into patch_realtek for this SSID.
>
> Stefan Binding (4):
> ALSA: hda: cs35l41: Support Lenovo Thinkbook 16P Gen 5
> ALSA: hda: cs35l41: Support Lenovo Thinkbook 13x Gen 4
> ALSA: hda/realtek: Support Lenovo Thinkbook 16P Gen 5
> ALSA: hda/realtek: Support Lenovo Thinkbook 13x Gen 4
Applied all patches. I corrected the hex numbers in the patch 3 to
lower cases.
thanks,
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread